catch bad token sooner

ref #415
OuhscBbmc · Sep 5, 2022 · 4c82e12 · 4c82e12
1 parent 9383f55
commit 4c82e12
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 9 deletions.
diff --git a/R/redcap-read.R b/R/redcap-read.R
@@ -273,13 +273,13 @@ redcap_read <- function(
     config_options     = config_options
   )
 
-  # if (!metadata$success) {
-  #   error_message     <- sprintf(
-  #     "The REDCapR record export operation was not successful.  The error message was:\n%s",
-  #     metadata$raw_text
-  #   )
-  #   stop(error_message)
-  # }
+  if (!metadata$success) {
+    error_message     <- sprintf(
+      "The REDCapR record export operation was not successful.  The error message was:\n%s",
+      metadata$raw_text
+    )
+    stop(error_message)
+  }
 
   initial_call <- REDCapR::redcap_read_oneshot(
     redcap_uri                 = redcap_uri,

diff --git a/tests/testthat/test-read-batch-simple.R b/tests/testthat/test-read-batch-simple.R
@@ -620,8 +620,8 @@ test_that("date-range", {
 test_that("error-bad-token", {
   testthat::skip_on_cran()
 
-  expected_outcome_message <- "The REDCapR read/export operation was not successful\\."
-  expect_message(
+  expected_outcome_message <- "The REDCapR record export operation was not successful\\."
+  expect_error(
     regexp           = expected_outcome_message,
     redcap_read(
       redcap_uri    = credential$redcap_uri,