remove old testthat functions

ref #312
OuhscBbmc · Nov 19, 2020 · 2a97d24 · 2a97d24
1 parent ecf005e
commit 2a97d24
Show file tree

Hide file tree

Showing 4 changed files with 1 addition and 15 deletions.
diff --git a/tests/testthat/test-read-clinical-trial.R b/tests/testthat/test-read-clinical-trial.R
@@ -30,9 +30,6 @@ test_that("default", {
   expect_true(returned_object$filter_logic=="", "A filter was not specified.")
   expect_match(returned_object$outcome_message, regexp=expected_outcome_message, perl=TRUE)
   expect_true(returned_object$success)
-
-  # expect_equal_to_reference(returned_object$data, file=system.file("test-data/project-simple/variations/default.rds", package="REDCapR"))
-  # expect_equal_to_reference(returned_object$data, file="./test-data/project-simple/variations/default.rds")
 })
 
 rm(credential)
diff --git a/tests/testthat/test-read-oneshot-eav.R b/tests/testthat/test-read-oneshot-eav.R
@@ -31,8 +31,6 @@ test_that("default", {
   expect_true(returned_object$filter_logic=="", "A filter was not specified.")
   expect_match(returned_object$outcome_message, regexp=expected_outcome_message, perl=TRUE)
   expect_true(returned_object$success)
-  #expect_equal_to_reference(returned_object$data, file=system.file("test-data/project-simple/variations/default.rds", package="REDCapR"))
-  #expect_equal_to_reference(returned_object$data, file="./test-data/project-simple/variations/default.rds")
 })
 test_that("specify-forms", {
   testthat::skip_on_cran()
@@ -56,8 +54,6 @@ test_that("specify-forms", {
   expect_true(returned_object$filter_logic=="", "A filter was not specified.")
   expect_match(returned_object$outcome_message, regexp=expected_outcome_message, perl=TRUE)
   expect_true(returned_object$success)
-  #expect_equal_to_reference(returned_object$data, file=system.file("test-data/project-simple/variations/default.rds", package="REDCapR"))
-  #expect_equal_to_reference(returned_object$data, file="./test-data/project-simple/variations/default.rds")
 })
 test_that("raw", {
   testthat::skip_on_cran()

diff --git a/tests/testthat/test-read-oneshot.R b/tests/testthat/test-read-oneshot.R
@@ -70,9 +70,6 @@ test_that("col_types", {
   expect_true(returned_object$filter_logic=="", "A filter was not specified.")
   expect_match(returned_object$outcome_message, regexp=expected_outcome_message, perl=TRUE)
   expect_true(returned_object$success)
-
-  # expect_equal_to_reference(returned_object$data, file=system.file("test-data/project-simple/variations/default.rds", package="REDCapR"))
-  # expect_equal_to_reference(returned_object$data, file="./test-data/project-simple/variations/default.rds")
 })
 test_that("specify-forms", {
   testthat::skip_on_cran()
@@ -96,8 +93,6 @@ test_that("specify-forms", {
   expect_true(returned_object$filter_logic=="", "A filter was not specified.")
   expect_match(returned_object$outcome_message, regexp=expected_outcome_message, perl=TRUE)
   expect_true(returned_object$success)
-  #expect_equal_to_reference(returned_object$data, file=system.file("test-data/project-simple/variations/default.rds", package="REDCapR"))
-  #expect_equal_to_reference(returned_object$data, file="./test-data/project-simple/variations/default.rds")
 })
 test_that("force-character-type", {
   testthat::skip_on_cran()
@@ -120,8 +115,6 @@ test_that("force-character-type", {
   expect_true(returned_object$filter_logic=="", "A filter was not specified.")
   expect_match(returned_object$outcome_message, regexp=expected_outcome_message, perl=TRUE)
   expect_true(returned_object$success)
-  #expect_equal_to_reference(returned_object$data, file=system.file("test-data/project-simple/variations/default.rds", package="REDCapR"))
-  #expect_equal_to_reference(returned_object$data, file="./test-data/project-simple/variations/default.rds")
 })
 test_that("raw", {
   testthat::skip_on_cran()

diff --git a/tests/testthat/test-utilities-replace_nas_with_explicit.R b/tests/testthat/test-utilities-replace_nas_with_explicit.R
@@ -12,7 +12,7 @@ test_that("replace_nas_character_standard", {
 
   a <- REDCapR:::replace_nas_with_explicit(a)
   expect_equal(a, expected, label="The correct letters should have been replaced.")
-  expect_equal(class(a), "character")
+  expect_type(a, "character")
 })
 
 test_that("replace_nas_factor_standard", {