Skip to content

Commit

Permalink
Add the DoubleConversion dependency to third-party libraries (faceboo…
Browse files Browse the repository at this point in the history
…k#41972)

Summary:
Pull Request resolved: facebook#41972

This diff adds the `DoubleConversion` dependency to the `install_modules_dependencies` function, that installs all the dependencies that third-party libraries might need.
The libraries will need the `DoubleConversion` pod if they include the generated Fabric files.

Changelog: [Internal]

Reviewed By: cipolleschi

Differential Revision: D51848314

fbshipit-source-id: ae2ce022c6f51ce392852494c61e26ff810d30d0
  • Loading branch information
dmytrorykun authored and Othinn committed Jan 9, 2024
1 parent afd6332 commit 6c6a899
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -163,6 +163,7 @@ def test_installModulesDependencies_whenNewArchEnabledAndNewArchAndNoSearchPaths
{ :dependency_name => "React-debug" },
{ :dependency_name => "React-ImageManager" },
{ :dependency_name => "React-rendererdebug" },
{ :dependency_name => "DoubleConversion" },
{ :dependency_name => "hermes-engine" }
])
end
Expand Down Expand Up @@ -203,6 +204,7 @@ def test_installModulesDependencies_whenNewArchDisabledAndSearchPathsAndCompiler
{ :dependency_name => "React-debug" },
{ :dependency_name => "React-ImageManager" },
{ :dependency_name => "React-rendererdebug" },
{ :dependency_name => "DoubleConversion" },
{ :dependency_name => "hermes-engine" }
]
)
Expand Down
2 changes: 2 additions & 0 deletions packages/react-native/scripts/cocoapods/new_architecture.rb
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,8 @@ def self.install_modules_dependencies(spec, new_arch_enabled, folly_version)
spec.dependency "React-debug"
spec.dependency "React-ImageManager"
spec.dependency "React-rendererdebug"
# This dependency is required for the cases when the pod includes generated sources, specifically Props.cpp.
spec.dependency "DoubleConversion"

if ENV["USE_HERMES"] == nil || ENV["USE_HERMES"] == "1"
spec.dependency "hermes-engine"
Expand Down

0 comments on commit 6c6a899

Please sign in to comment.