Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/localized clients #26

Merged
merged 6 commits into from
Jan 29, 2023
Merged

Conversation

MassCraxx
Copy link
Contributor

@MassCraxx MassCraxx commented Jan 28, 2023

Currently localized clients (using any language other than enUS) run into some problems using the AddOn:

  • On joining a raid the message will contain the localized Class name, which is bad when playing on an international server
  • Saved raids coming from the client contain localized Raid names, the comparision with the provided raid_list fails.

These changes should solve these issues making sure a predefined Class-Spec name is used for the join message and using a translation lib to compare localized raid names.
Unfortunately comparing Raid IDs seems not to be possible so I assume this is the best solution.

Please note I also adjusted the join message a bit ("LFG icc25 - 5857gs Discipline Priest") - I hope we will find a solution to adjust it in-game in the future.

@MassCraxx MassCraxx force-pushed the fix/localized-clients branch from d4b4e58 to ed1613e Compare January 28, 2023 17:12
cleanup
@MassCraxx MassCraxx force-pushed the fix/localized-clients branch from ed1613e to c15eed2 Compare January 28, 2023 17:14
@Ostoic Ostoic added the enhancement New feature or request label Jan 29, 2023
@Ostoic
Copy link
Owner

Ostoic commented Jan 29, 2023

This will be a good change for non enUS users.

With regards to your last point, I was thinking of adding AceConfig to improve the UX. From what I recall, this will add a section to the AddOns tab in the Interface frame and we can put an input box for the join message, perhaps with support for RaidBrowser parameters ($achieve or %achieve%, $class, etc). I also believe changing the OnDoubleClick click behavior for joining raids should be configurable, as some people (#27 (comment)) liked that feature.

In any case, I'll have to test these changes first before accepting the pull, so give me a few hours at the minimum. Thanks again!

@Ostoic
Copy link
Owner

Ostoic commented Jan 29, 2023

The only problem I see with this form of the join message is that people with chat addons that highlight the words "inv" or "invite" won't benefit from convenient click-invites anymore. I think I'd like to keep this the way it was originally and then allow for custom join messages using the above-mentioned config frame. If you could revert that change then I will accept the pull.

@Ostoic Ostoic mentioned this pull request Jan 29, 2023
@Ostoic Ostoic merged commit 662d78a into Ostoic:master Jan 29, 2023
@MassCraxx MassCraxx deleted the fix/localized-clients branch January 30, 2023 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants