Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added var $subx to change default via $_GET subject #10

Closed
wants to merge 1 commit into from

Conversation

gabamnml
Copy link

this change in code using another emerged wanting to send web page with just one click the matter which needs to support automatically adding the subject

<tr>
<th><?php echo $trl->translate('LABEL_SUBJECT')?>:</th>
<td>
<input type="text" name="subject" size="35" value="<?php echo $subx ?><?php echo $info['subject']?>">
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

value via get chage here

@carlosdelfino
Copy link
Member

hi @gabamnml, use the main branch only for translation, please!

code changes or new features make sure that there is a branch or create a new compatible and offer your suggestion with this branch to verify and discuss.

If the group approves we will be happy to take your proposal.

Thank you.

@jasperf
Copy link
Member

jasperf commented Oct 22, 2011

Would love to hear the reason for this patch/change

@gabamnml
Copy link
Author

Hi Jasper
Send a subject of the ticket, using Get. For use in applications such as Feedback

@jasperf
Copy link
Member

jasperf commented Oct 22, 2011

I see. well that does sound interesting. We'll wait for Carlos to join the conversation again later today or when he gets online. I guess you and I are in a similar timezone. I am at GMT+7/Bangkok. Carlos however is on Brazil time..

@jasperf jasperf reopened this Oct 22, 2011
@gabamnml
Copy link
Author

My time is GMT -4 Santiago. Currently here are the 1:10 a.m.

@jasperf
Copy link
Member

jasperf commented Oct 22, 2011

I see. Working late huh ;-) FYI I am at jasperfrumau (at} gmail.com for a Gchat on OsTicket. Just did a pull request and will do some quick tests today. It has been a while..

@gabamnml
Copy link
Author

Adds it to Gtalk. Mine is aramburu.gabriel at gmail.com go to sleep was a very tiring day. Tomorrow I'll see the progress of the issue

@carlosdelfino
Copy link
Member

Gays, I think not a good idea make new resources on master branch, create a new branch for new proposals changes.

Ok? :)

@jasperf
Copy link
Member

jasperf commented Oct 26, 2011

A new branch for a tiny change? I do not see the use of that myself unless many small changes follow. But if gabamnml wants to create a new branch based on this current master that is fine by me.

@carlosdelfino
Copy link
Member

Jasper and other friends want to focus on finishing the translation in the foreground, the service is quite simple but there is much to be done! :)
not understand that this is a complication, I'm trying to avoid lose focus on work, if not a precedent for other minor changes are accepted but the front. : D

@gabamnml
Copy link
Author

@jasperf here OsTicketReloaded have a fork with my changes so you can use https://github.com/gabamnml/OsTicket .
But do not want to undermine that change was something I saw very important to expose. If you do not want to use, no problems

@jasperf
Copy link
Member

jasperf commented Oct 27, 2011

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants