Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(GUI): performance #174

Merged
merged 7 commits into from
May 29, 2023
Merged

perf(GUI): performance #174

merged 7 commits into from
May 29, 2023

Conversation

hellmor
Copy link
Collaborator

@hellmor hellmor commented May 25, 2023

Improve GUI.
Add performance sample.

@hellmor
perf(GUI): performance
3563d8a 
Improve GUI.
Add performance sample.
@hellmor
fix(GUI): revert a sample.
6cc9234 
revert a sample.
@hellmor
fix(GUI): render gui errors
59323e1 
fix some errors of rebuild gui
@hellmor hellmor added the feature New feature or request label May 25, 2023
@hellmor hellmor added this to the 0.6 milestone May 25, 2023
@hellmor
fix(GUI): fix imageType
c704d74 
When the imageType changes, the position attribute needs to be changed
@lslzl3000
Copy link
Collaborator

tried with 30000 sprites, drop fps with toggleMove

looks like it lost performance on update transform
Screenshot 2023-05-25 at 18 59 23

and rebuildGUIMesh also takes a lot of time
Screenshot 2023-05-25 at 19 08 00

@hellmor
chore(GUI): simplified code
3b2d490 
simplified code
@hellmor
feat(GUI): UIImageGroup.ts newly added
04f4fa4 
See Sample_UIPerformance2.ts
@hellmor
Copy link
Collaborator Author

hellmor commented May 25, 2023

tried with 30000 sprites, drop fps with toggleMove

looks like it lost performance on update transform Screenshot 2023-05-25 at 18 59 23

and rebuildGUIMesh also takes a lot of time Screenshot 2023-05-25 at 19 08 00

See Sample_UIPerformance2.ts

@hellmor
fix(gui): UIGroup offset
c27e269 
fix the erro of layout sprites.
@X-OldGentleMan X-OldGentleMan merged commit 58ad344 into Orillusion:dev May 29, 2023
@lslzl3000 lslzl3000 mentioned this pull request May 30, 2023
Merged
@hellmor hellmor deleted the guiPerformance branch June 1, 2023 06:42
@lslzl3000 lslzl3000 mentioned this pull request Aug 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Codeboy-cn Codeboy-cn Codeboy-cn approved these changes

@lslzl3000 lslzl3000 lslzl3000 approved these changes

@X-OldGentleMan X-OldGentleMan Awaiting requested review from X-OldGentleMan

Assignees
No one assigned
Labels
feature New feature or request
Projects
Engine
Status: ✅ Done
Milestone
0.6
Development

Successfully merging this pull request may close these issues.
4 participants
@hellmor @lslzl3000 @Codeboy-cn @X-OldGentleMan