feat: broadcast #836
Merged
feat: broadcast #836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
geokaralis
added
new component
v5
geokaralis
force-pushed
the
feat/CDP-294-broadcast
branch
from
fa16236 to
26d5cdf
Compare
kostasdano
reviewed
Nov 19, 2024
| align-items: center; | ||
| background: ${theme.tokens.colors.get('palette.secondary.muted')}; | ||
| border-radius: ${theme.dimension.borderRadius.get('md')}; | ||
| border: 1px solid ${getBorderColor(props.status, theme)}; |
There was a problem hiding this comment.
why 1px and not var(--_border-width) ?
There was a problem hiding this comment.
Good catch we missed this in InlineAlert as well. I will update it in both places.
kostasdano
approved these changes
Nov 19, 2024
geokaralis
force-pushed
the
feat/CDP-308-slot-provider
branch
from
06bed9f to
fa1fa3f
Compare
geokaralis
force-pushed
the
feat/CDP-294-broadcast
branch
from
26d5cdf to
fa30192
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
<Broadcast />v5.