Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: inline alert v5 #830

Merged
merged 5 commits into from
Oct 1, 2024
Merged

feat: inline alert v5 #830

merged 5 commits into from
Oct 1, 2024

Conversation

geokaralis
Copy link
Contributor

Description

<InlineAlert /> v5.

Accessibility

Adheres to the WAI-ARIA alert pattern.

@geokaralis geokaralis added v5 This feature will be released on version 5 (next) new component labels Sep 17, 2024
@geokaralis geokaralis marked this pull request as ready for review September 18, 2024 12:52
@geokaralis geokaralis requested a review from a team as a code owner September 18, 2024 12:52
@panvourtsis
Copy link
Collaborator

in terms of documentation i suggest 2 things

  1. create a notification section and have inline and future notifications under it. This will be easier to have all in one place as per design as well.
  2. Refer to the old notification that are deprecated and link to new section. Also code wise we can use @deprecated tag to notify us when we are about to use them

@panvourtsis
Copy link
Collaborator

panvourtsis commented Sep 19, 2024 •
edited
Loading

only small suggestions from my side, really good work 🚀

@geokaralis geokaralis temporarily deployed to review-830 September 23, 2024 06:21 — with GitHub Actions Inactive
kostasdano
kostasdano reviewed Sep 23, 2024
View reviewed changes
src/components/InlineAlert/InlineAlert.style.ts
min-height: var(--_min-height);
outline: none;
outline-offset: 2px;
transition: outline-offset 150ms cubic-bezier(0.4, 0, 0.2, 1);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like the cubic-bezier usage here. nice touch👌

@kostasdano
Copy link
Collaborator

minor comments mostly for consistency from my side also, great work and and really nice touches introduced! welcome to DS 🎨 🎉

@github-actions github-actions bot temporarily deployed to review-830 September 24, 2024 10:52 Inactive
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

kostasdano
kostasdano approved these changes Sep 25, 2024
View reviewed changes
Copy link
Collaborator

@kostasdano kostasdano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

really nice job 🎉

@geokaralis geokaralis merged commit 0f8391e into master Oct 1, 2024
13 of 15 checks passed
@geokaralis geokaralis deleted the feat/inline-alert branch October 1, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsevdos tsevdos tsevdos left review comments

@kostasdano kostasdano kostasdano approved these changes

@panvourtsis panvourtsis Awaiting requested review from panvourtsis

Assignees
No one assigned
Labels
new component v5 This feature will be released on version 5 (next)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@geokaralis @panvourtsis @kostasdano @tsevdos