Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NDS-809] feat: revisit typography parsing mechanism [v5] #676

Merged
merged 6 commits into from
Oct 4, 2023
Merged

[NDS-809] feat: revisit typography parsing mechanism [v5] #676

merged 6 commits into from
Oct 4, 2023

Conversation

kostasdano
Copy link
Collaborator

@kostasdano kostasdano commented Oct 2, 2023 •
edited by jira bot
Loading

Description

NDS-809

  • Update Typography Tokens and Typography component with new typography variations.
  • Update Typography Tokens Parsing Mechanism to simplify typography usage across components.
  • Update Avatar and Button typography usages.

@kostasdano kostasdano marked this pull request as ready for review October 2, 2023 07:39
@kostasdano kostasdano requested a review from a team as a code owner October 2, 2023 07:39
panvourtsis
panvourtsis reviewed Oct 3, 2023
View reviewed changes
Copy link
Collaborator

@panvourtsis panvourtsis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really good job once more but lets see typescript and if we can optimize tests

src/components/Avatar/Avatar.tokens.ts Outdated Show resolved Hide resolved
src/components/Avatar/Avatar.tokens.ts Outdated Show resolved Hide resolved
src/components/Button/Button.tokens.ts Outdated Show resolved Hide resolved
@kostasdano kostasdano requested a review from panvourtsis October 3, 2023 12:24
@orfium-sonarqube-app
Copy link

SonarQube Quality Gate

Quality Gate failed

Failed condition 73.9% 73.9% Coverage on New Code (is less than 80%)

See analysis details on SonarQube

@kostasdano kostasdano merged commit 79ef59d into next Oct 4, 2023
10 checks passed
@kostasdano kostasdano deleted the feat/NDS-809_revisit_typography_parsing_mechanism_v5 branch October 4, 2023 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@panvourtsis panvourtsis panvourtsis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kostasdano @panvourtsis