[NDS-807] fix: select backspace does not clear value [v5] #674

kostasdano · 2023-09-26T11:23:58Z

Description

In this PR:

the Backspace issue is resolved: when Backspace is clicked on SingleSelect while the input value equals the selected option's label, then the Select will be cleared (that also fixes the issue of non-searchable Select where you cannot clear the field)
as implemented on v4, the empty state of Select from now on is undefined ; so when the field is cleared, the onChange is called with undefined as an argument.
Typos are fixed.
Async Select Showcase wasn't working properly; now it's fixed.

src/components/Select/Select.tsx

orfium-sonarqube-app · 2023-09-27T11:07:27Z

SonarQube Quality Gate

Maintainability Rating on New Code (is worse than A)

Fix issues before they fail your Quality Gate with SonarLint in your IDE.

kostasdano added 2 commits September 26, 2023 14:06

fix: handle backspace for Select

46544b8

fix: async select showcase

13152b0

kostasdano marked this pull request as ready for review September 26, 2023 11:24

kostasdano requested a review from a team as a code owner September 26, 2023 11:24

panvourtsis reviewed Sep 27, 2023

View reviewed changes

src/components/Select/Select.tsx Show resolved Hide resolved

panvourtsis approved these changes Sep 27, 2023

View reviewed changes

feat: add comment

a0ca577

kostasdano merged commit eb363f7 into feat/NDS-701_textfields_v5 Sep 27, 2023
5 checks passed

kostasdano deleted the fix/NDS-807_select_backspace_does_not_clear_value_v5 branch September 27, 2023 11:01

kostasdano deployed to review-674 September 27, 2023 11:06 — with GitHub Actions View deployment