New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NDS-798] fix: select backspace does not change value [v4] #673

Merged

kostasdano merged 1 commit into master from fix/NDS-798_select_backspace_does_not_change_value

Sep 25, 2023

Collaborator

kostasdano commented Sep 25, 2023 •

edited

Loading

Description

In this PR:

Single Select: Backspace triggers the handleSelectedOption callback (external prop) with undefined.
Multi Select: While BackSpace already deletes the last item from the inner state of selected options, it now also triggers the onOptionDelete callback (external prop) with the last item of the selectedOptions[] as an argument (this callback was only triggered when the X icon of the Chip-Option was clicked)


          fix: select backspace does not change value

orfium-sonarqube-app bot commented Sep 25, 2023

SonarQube Quality Gate

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

50.0% Coverage
0.0% Duplication

kostasdano marked this pull request as ready for review

September 25, 2023 14:09

kostasdano requested a review from a team as a code owner

September 25, 2023 14:09

kostasdano requested a review from tentascoding

September 25, 2023 14:09

tentascoding reviewed

View reviewed changes

Contributor

tentascoding left a comment

tentascoding approved these changes

View reviewed changes

Contributor

tentascoding left a comment

kostasdano merged commit c5ab01f into master

kostasdano deleted the fix/NDS-798_select_backspace_does_not_change_value branch

September 25, 2023 17:04

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet