Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NDS-701] New Fields #672

Merged
merged 149 commits into from
Oct 16, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
149 commits
Select commit Hold shift + click to select a range
97ce986
feat: TextInputBase new tokens
kostasdano Jun 12, 2023
7effa3f
feat: TextInputBase props and styles update
kostasdano Jun 12, 2023
c16381e
feat: update all components based on new props
kostasdano Jun 12, 2023
50a49f9
feat: update Label style
kostasdano Jun 12, 2023
c8901db
feat: update storybook
kostasdano Jun 12, 2023
2f8d293
feat: update snapshots
kostasdano Jun 12, 2023
b288c59
feat: pr comments
kostasdano Jun 13, 2023
2da066f
fix: prop types
kostasdano Jun 14, 2023
b8f6798
feat: memoize components
kostasdano Jun 14, 2023
c95e0c7
Merge pull request #634 from Orfium/feat/NDS-707_new_text_input_base
kostasdano Jun 14, 2023
ca75086
feat: remove prefix
kostasdano Jun 21, 2023
3cb7fef
Merge branch 'feat/NDS-701_textfields_v5' of https://github.com/Orfiu…
kostasdano Jun 21, 2023
be5bd9e
Merge branch 'feat/NDS-701_textfields_v5' into feat/NDS-702_new_textf…
kostasdano Jun 21, 2023
6291810
feat: make textfield controlled
kostasdano Jun 25, 2023
77c133e
feat: multitextfield ui changes
kostasdano Jun 25, 2023
4a90552
feat: tests and storyshots
kostasdano Jun 25, 2023
7bc2ff8
feat: change label and placeholder logic
kostasdano Jun 27, 2023
fbc022f
fix: tests
kostasdano Jun 27, 2023
850cdc3
Merge branch 'next' into feat/NDS-701_textfields_v5
panvourtsis Jun 27, 2023
3c45b94
feat: pr comments
kostasdano Jun 28, 2023
16ef0cd
feat: add aria hidden and fix padding
kostasdano Jun 29, 2023
0a3037f
fix: id generation in tests
kostasdano Jun 30, 2023
aed1fcb
Merge pull request #638 from Orfium/feat/NDS-702_new_textfield_v5
kostasdano Jun 30, 2023
80d57ef
feat: new textarea
kostasdano Jul 3, 2023
e4c7917
feat: storybook documentation
kostasdano Jul 3, 2023
129d9bc
feat: snapshots
kostasdano Jul 3, 2023
c3b68eb
feat: add mask prop to textfield
kostasdano Jul 7, 2023
1460173
feat: add showcase
kostasdano Jul 7, 2023
3a53da0
feat: add tests
kostasdano Jul 7, 2023
00c93ce
feat: pr comments
kostasdano Jul 10, 2023
f70729b
fix: remove false import
kostasdano Jul 10, 2023
7c45d18
Merge pull request #643 from Orfium/feat/NDS-706_textarea_v5
kostasdano Jul 11, 2023
c6d4b0f
chore: update storybook deps and typescript
panvourtsis Jul 18, 2023
003ae87
fix(DemoUseSearchQueryParams): type on DemoUseSearchQueryParams.tsx
panvourtsis Jul 18, 2023
8e5575d
feat(ClickAwayListener): pass aria role and remove the default role, …
panvourtsis Jul 18, 2023
170f3e0
feat(Select): use react-aria for keyboard navigation and create state…
panvourtsis Jul 18, 2023
97bf773
chore(list): make the list of showcase smaller
panvourtsis Jul 18, 2023
bb10ec6
feat: add react-aria-components
kostasdano Jul 20, 2023
117e284
feat: introduce NumberField
kostasdano Jul 20, 2023
b53f663
feat: create stories
kostasdano Jul 20, 2023
8917283
feat: tests
kostasdano Jul 20, 2023
4551aa4
feat: storyshots
kostasdano Jul 20, 2023
158ab59
fix: tests
kostasdano Jul 20, 2023
c61220b
feat(list): change aria list to barebone aria
panvourtsis Jul 21, 2023
bb95a04
Merge pull request #645 from Orfium/feat/NDS-704_masked_textfield
kostasdano Jul 24, 2023
1f2bba0
feat(list): change list to separate components
panvourtsis Jul 26, 2023
a45393c
feat: pr comments
kostasdano Jul 26, 2023
be1d40c
Merge pull request #649 from Orfium/feat/NDS-705_number_field_v5
kostasdano Jul 27, 2023
76b4764
feat(list): update tests and documentation for all
panvourtsis Jul 27, 2023
ae980e7
chore: remove isDefaultOption as it is not needed
panvourtsis Jul 27, 2023
3b16bc4
chore(List): update onSelecitonChange callback with named functions
panvourtsis Jul 31, 2023
448650c
chore(List): fix background with theme.globals.colors.white for consi…
panvourtsis Jul 31, 2023
e66fc4c
chore(List): add label prop description
panvourtsis Jul 31, 2023
514f83b
chore(List): leave a TODO for list on searchTerm and isSearchable props
panvourtsis Jul 31, 2023
37ecdea
docs(List): adding documentation explaining the reasoning on one comp…
panvourtsis Jul 31, 2023
c11cdfc
style(List): change style to css prop
panvourtsis Jul 31, 2023
a660901
chore(List): comment highlight code leftover
panvourtsis Jul 31, 2023
d91f92f
chore: remove unused debugger and screen.debug from tests
panvourtsis Jul 31, 2023
9e881c5
docs(SelectMenu): add explanation and naming constant for list height
panvourtsis Jul 31, 2023
0363daa
chore(List): move item height to global consts
panvourtsis Jul 31, 2023
a81f751
chore(List): fix inconsistency on list item height with global consts
panvourtsis Jul 31, 2023
392e85a
Merge pull request #655 from Orfium/feat/list-v5
panvourtsis Jul 31, 2023
41c5778
Merge branch 'feat/NDS-701_textfields_v5' into feat/NDS-703-select_v5
panvourtsis Aug 2, 2023
55b8ff7
chore: fix PR comments
panvourtsis Aug 7, 2023
923ca24
Merge pull request #647 from Orfium/feat/NDS-703-select_v5
panvourtsis Aug 8, 2023
7b6fe5e
Merge branch 'next' into feat/NDS-765_update_field_tokens
kostasdano Aug 22, 2023
9f2993b
feat: update field tokens
kostasdano Aug 22, 2023
7826a69
feat: update obsolete token usages
kostasdano Aug 25, 2023
9a3ec8d
feat: add listItem and menu tokens
kostasdano Aug 28, 2023
7915467
feat: snapshots
kostasdano Aug 28, 2023
06bb67f
Merge branch 'next' into feat/merge_next_to_701
kostasdano Aug 28, 2023
b0e961e
feat: necessary changes for app to build
kostasdano Aug 28, 2023
416819d
Merge branch 'feat/merge_next_to_701' into feat/NDS-765_update_field_…
kostasdano Aug 28, 2023
433c439
feat: add boxShadow to List
kostasdano Aug 29, 2023
40133bf
fix: typo
kostasdano Aug 29, 2023
c84041e
Merge branch 'next' into feat/merge_next_to_701
kostasdano Aug 30, 2023
6ed8abc
Merge pull request #662 from Orfium/feat/merge_next_to_701
kostasdano Aug 30, 2023
7eb6c41
Merge pull request #663 from Orfium/feat/NDS-765_update_field_tokens
kostasdano Aug 30, 2023
f50c665
feat: import date and datepicker tokens
kostasdano Sep 4, 2023
a09a6df
fix: textfield sx props
kostasdano Sep 4, 2023
cf772da
feat: reduce DatePicker file size
kostasdano Sep 5, 2023
2cdd2e9
feat: make constants file
kostasdano Sep 5, 2023
3819046
feat: styles
kostasdano Sep 5, 2023
b21aa72
feat: change components
kostasdano Sep 5, 2023
3874160
feat: tests
kostasdano Sep 5, 2023
62dfb3a
feat: stories
kostasdano Sep 5, 2023
e7ab804
feat: snapshots
kostasdano Sep 5, 2023
0b962fd
fix: tests
kostasdano Sep 5, 2023
394f623
feat: add options prop
kostasdano Sep 5, 2023
32e371e
feat: export types
kostasdano Sep 6, 2023
a97a686
fix: unused import
kostasdano Sep 6, 2023
5ee104f
feat: open datePicker before snapshot test
kostasdano Sep 6, 2023
728df87
feat: date picker and date input leftovers
kostasdano Sep 7, 2023
0a63053
feat: overlay component onClear
kostasdano Sep 7, 2023
2331a2c
feat: tests
kostasdano Sep 7, 2023
dcc3c2f
feat: stories
kostasdano Sep 7, 2023
9ce5998
feat: snapshots
kostasdano Sep 7, 2023
faa1f89
Merge pull request #665 from Orfium/feat/NDS-785_date_picker_ui_changes
kostasdano Sep 7, 2023
88937f4
feat: pr comments
kostasdano Sep 7, 2023
2c7e89d
Merge pull request #666 from Orfium/feat/NDS-792_date_picker_leftovers
kostasdano Sep 12, 2023
e332257
fix: date picker calendar days hidden v5
kostasdano Sep 12, 2023
dde80ab
feat(NDS-805): calendar not rendering with initial values
kostasdano Sep 13, 2023
0ca3366
fix(NDS-805): simplify the initial values calculation
kostasdano Sep 13, 2023
fc5704d
feat(tests): add test-ids
kostasdano Sep 13, 2023
a496cd2
feat(tests): add tests
kostasdano Sep 13, 2023
4efb840
feat(tests): snaps
kostasdano Sep 13, 2023
287dabd
feat: refactor useKeyBoardEvents
kostasdano Sep 14, 2023
f05b31f
feat: refactor callback on DatePicker
kostasdano Sep 14, 2023
834963d
feat: keyboard navigation for DatePickInput
kostasdano Sep 14, 2023
02f6e9e
fix: import on Select
kostasdano Sep 14, 2023
90eebc3
feat: keyboard navigation for Calendar grid
kostasdano Sep 14, 2023
f41fcbe
feat: keyboard navigation for Month Selection
kostasdano Sep 14, 2023
d1d88da
feat: snaps
kostasdano Sep 14, 2023
56e17a3
feat: add documentation
kostasdano Sep 20, 2023
560abec
Merge branch 'fix/NDS-799_date_picker_calendar_days_hidden_v5' into f…
kostasdano Sep 20, 2023
d848765
feat: pr comments
kostasdano Sep 20, 2023
44b2987
feat: tests
kostasdano Sep 20, 2023
eb1b577
Merge pull request #668 from Orfium/fix/NDS-799_date_picker_calendar_…
kostasdano Sep 21, 2023
46d9553
feat: work in progress
kostasdano Sep 21, 2023
bdd19b1
fix: tests
kostasdano Sep 21, 2023
0e33bc6
feat: increase coverage
kostasdano Sep 21, 2023
cb109a5
feat: remove unreached code
kostasdano Sep 21, 2023
fa3fb80
fix: Escape DatePicker
kostasdano Sep 22, 2023
0211d71
Merge pull request #669 from Orfium/feat/NDS-781_date_picker_keyboard…
kostasdano Sep 22, 2023
46544b8
fix: handle backspace for Select
kostasdano Sep 26, 2023
13152b0
fix: async select showcase
kostasdano Sep 26, 2023
a0ca577
feat: add comment
kostasdano Sep 27, 2023
eb363f7
Merge pull request #674 from Orfium/fix/NDS-807_select_backspace_does…
kostasdano Sep 27, 2023
99485fd
refactor: textfield showcases and storybook
kostasdano Sep 28, 2023
279d6e3
fix: isDisabled should override status
kostasdano Sep 28, 2023
7683fe6
Merge branch 'next' into feat/NDS-701_textfields_v5
kostasdano Oct 4, 2023
747a54e
feat: update snapshots after typography changes from merge
kostasdano Oct 4, 2023
1f84a3a
Merge branch 'feat/NDS-701_textfields_v5' into feat/NDS-810_design_qa…
kostasdano Oct 4, 2023
f95ca23
Merge branch 'next' into feat/NDS-701_textfields_v5
kostasdano Oct 9, 2023
b1a4074
Merge branch 'feat/NDS-701_textfields_v5' into feat/NDS-810_design_qa…
kostasdano Oct 9, 2023
dc89480
feat: change apply dates to apply
kostasdano Oct 10, 2023
5644192
feat: update tokens
kostasdano Oct 10, 2023
40e8585
feat: update style files
kostasdano Oct 10, 2023
71c1643
feat: update components
kostasdano Oct 10, 2023
f02befa
feat: remove config
kostasdano Oct 10, 2023
1531808
feat: showcases and stories
kostasdano Oct 10, 2023
f235142
feat: storyshots
kostasdano Oct 10, 2023
f28779a
fix: numberfield stories
kostasdano Oct 11, 2023
d32bd15
feat: list dqa
kostasdano Oct 11, 2023
d47fd76
feat: more dqa comments
kostasdano Oct 13, 2023
58e612e
fix: TextArea error and disabled
kostasdano Oct 13, 2023
d79091b
fix: textarea playground
kostasdano Oct 16, 2023
965825f
Merge pull request #675 from Orfium/feat/NDS-810_design_qa_for_fields_v5
kostasdano Oct 16, 2023
4c64e1a
Merge branch 'next' into feat/NDS-701_textfields_v5
kostasdano Oct 16, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .eslintrc.json
Original file line number Diff line number Diff line change
Expand Up @@ -124,11 +124,12 @@
}
},
"parser": "@typescript-eslint/parser",
"ignorePatterns": ["rollup.config.js"],
"parserOptions": {
"ecmaFeatures": {
"jsx": true
},
"ecmaVersion": 2018,
"ecmaVersion": 2022,
"sourceType": "module",
"project": ["./tsconfig.json"] // Specify it only for TypeScript files
}
Expand Down
18 changes: 9 additions & 9 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,19 +10,20 @@
"@amanda-mitchell/semantic-release-npm-multiple": "^2.8.0",
"@babel/cli": "^7.13.16",
"@babel/core": "^7.14.0",
"@babel/plugin-proposal-private-property-in-object": "^7.21.11",
"@babel/plugin-transform-runtime": "^7.13.15",
"@babel/polyfill": "^7.12.1",
"@babel/preset-env": "^7.14.1",
"@babel/preset-react": "^7.13.13",
"@babel/preset-typescript": "^7.13.0",
"@commitlint/cli": "^11.0.0",
"@commitlint/config-conventional": "^11.0.0",
"@emotion/react": "^11.4.0",
"@emotion/styled": "^11.3.0",
"@emotion/babel-plugin": "^11.10.5",
"@emotion/babel-preset-css-prop": "^11.10.0",
"@emotion/eslint-plugin": "^11.10.0",
"@emotion/jest": "^11.10.5",
"@emotion/react": "^11.4.0",
"@emotion/styled": "^11.3.0",
"@mdx-js/react": "^1.6.22",
"@optimize-lodash/rollup-plugin": "^4.0.1",
"@rollup/plugin-commonjs": "^23.0.7",
Expand All @@ -35,7 +36,7 @@
"@storybook/addon-docs": "^6.5.7",
"@storybook/addon-knobs": "^6.4.0",
"@storybook/addon-links": "^6.5.7",
"@storybook/addon-storyshots": "6.3.13",
"@storybook/addon-storyshots": "^6.5.7",
"@storybook/addon-storysource": "^6.5.7",
"@storybook/addon-viewport": "^6.5.7",
"@storybook/addons": "^6.5.7",
Expand All @@ -56,8 +57,8 @@
"@types/react": "^17.0.9",
"@types/react-dom": "^17.0.6",
"@types/react-highlight-words": "^0.16.1",
"@types/react-input-mask": "^3.0.2",
"@types/react-router-dom": "^5.1.5",
"@types/react-test-renderer": "^17.0.1",
"@types/recharts": "^1.8.16",
"@types/styled-components": "^5.1.7",
"@types/uuid": "^8.3.0",
Expand All @@ -83,7 +84,6 @@
"husky": "^6.0.0",
"identity-obj-proxy": "^3.0.0",
"jest": "^26.6.3",
"jest-specific-snapshot": "^4.0.0",
"jest-transform-stub": "^2.0.0",
"jest-webpack-resolver": "^0.3.0",
"lint-staged": "^11.0.0",
Expand All @@ -92,7 +92,6 @@
"react-dom": "^17.0.2",
"react-router": "^5.2.0",
"react-router-dom": "^5.2.0",
"react-test-renderer": "^16.13.1",
"rimraf": "^3.0.2",
"rollup": "3.9.1",
"rollup-plugin-delete": "^2.0.0",
Expand All @@ -106,23 +105,24 @@
"ts-jest": "^26.5.6",
"ts-loader": "^9.1.2",
"typedoc": "^0.22.12",
"typescript": "4.2.4",
"typescript": "4.9.5",
"url-loader": "^4.1.0"
},
"dependencies": {
"@tippyjs/react": "^4.2.5",
"@types/react-window": "^1.8.4",
"dayjs": "^1.8.34",
"emotion-reset": "^3.0.1",
"lodash": "^4.17.19",
"pluralize": "^8.0.0",
"polished": "^3.4.4",
"react-aria": "^3.26.0",
"react-aria-components": "^1.0.0-alpha.5",
"react-fast-compare": "^3.2.0",
"react-highlight-words": "^0.17.0",
"react-input-mask": "^2.0.4",
"react-media": "^2.0.0-rc.1",
"react-range": "^1.8.12",
"react-switch": "^6.0.0",
"react-window": "^1.8.6",
"recharts": "^1.8.5",
"tslib": "^2.4.1",
"uuid": "^8.3.2"
Expand Down
10 changes: 6 additions & 4 deletions rollup.config.js
Original file line number Diff line number Diff line change
@@ -1,22 +1,23 @@
import fs from 'fs';

import { optimizeLodashImports } from '@optimize-lodash/rollup-plugin';
import commonjs from '@rollup/plugin-commonjs';
import { nodeResolve } from '@rollup/plugin-node-resolve';
import typescript from '@rollup/plugin-typescript';
import svgr from '@svgr/rollup';
import { optimizeLodashImports } from '@optimize-lodash/rollup-plugin';
import del from 'rollup-plugin-delete';
import dts from 'rollup-plugin-dts';
import css from 'rollup-plugin-import-css';
// eslint-disable-next-line import/order
import peerDepsExternal from 'rollup-plugin-peer-deps-external';

// To handle css files
import { terser } from 'rollup-plugin-terser';

// @ts-ignore
// eslint-disable-next-line @typescript-eslint/no-var-requires
const pkg = require('./package.json');

const regexesOfPackages = (externalPackages = []) =>
externalPackages.map((packageName) => new RegExp(`^${packageName}(\/.*)?`));
externalPackages.map((packageName) => new RegExp(`^${packageName}(/.*)?`));

export default [
{
Expand All @@ -25,6 +26,7 @@ export default [
{
dir: 'dist',
format: 'esm',
// eslint-disable-next-line @typescript-eslint/naming-convention
preserveModules: true,
},
],
Expand Down
2 changes: 1 addition & 1 deletion src/components/Avatar/Avatar.stories.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ import SectionHeader from '../../storybook/SectionHeader';

## Overview

A universal Avatar component cam be found around ictinus on menus or can be a standalone component as well. It renders either images, letter or icon from our library
A universal Avatar component can be found around ictinus on menus or can be a standalone component as well. It renders either images, letter or icon from our library

## Props

Expand Down
5 changes: 3 additions & 2 deletions src/components/Breadcrumb/Breadcrumb.tsx
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import { isEmpty, uniqueId } from 'lodash';
import { isEmpty } from 'lodash';
import * as React from 'react';
import { Link } from 'react-router-dom';
import { generateUniqueKey } from 'utils/helpers';

import { breadcrumbLinkStyles, breadcrumbStyles } from './Breadcrumb.style';
import BreadcrumbItem from './BreadcrumbItem/BreadcrumbItem';
Expand Down Expand Up @@ -38,7 +39,7 @@ const Breadcrumb: React.FC<BreadcrumbProps> = ({ children, data = [] }) => {
const getBreadcrumbItem = React.useMemo(
// eslint-disable-next-line react/display-name
() => (child: React.ReactNode, index: number) => {
const itemKey = uniqueId('data_item_');
const itemKey = generateUniqueKey('data_item_');

const isLast = isLastItem(dataItems, index);

Expand Down
Loading
Loading