[NDS-795] feat: upgrading dependencies of react to 18 #670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
SonarQube Quality Gate
|
mkarajohn
approved these changes
Sep 19, 2023
There was a problem hiding this comment.
Personally I think this would be a great opportunity to completely drop the pattern of "typed" React components; I would much prefer for them to be written as function Component(props: Props) {} but as long as the implemented solution resolves the reported issue, it's fine by me.
panvourtsis
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR tends to solve typing for React 18. Any app that uses ictinus till this point have issues when they are using our library. From now on we are solving this and we are also backward compatible with React 17
You should expect to see:
React.FCto our new typeReactFCCwhich is the new component with children.Test Plan
Already tested with RC version on