Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NDS-792] date picker leftovers [v5] #666

Merged

Conversation

kostasdano
Copy link
Collaborator

@kostasdano kostasdano commented Sep 7, 2023

Description

NDS-792

  • Fix Filter Date Picker onClear functionality
  • Fix Date Picker onClear
  • Code cleanup
  • Fix Tests
  • Stories

@kostasdano kostasdano marked this pull request as ready for review September 7, 2023 07:38
@kostasdano kostasdano requested a review from a team as a code owner September 7, 2023 07:38
<UsageGuidelines
guidelines={['If you need to enter a date range, use date range picker instead']}
/>

```js
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i would remove this

@@ -164,9 +148,9 @@ Implementation of the regular DatePicker with options
</Story>
</Preview>

# DatePicker with Filter
### DatePicker with Filter
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we have something on figma on this? is this still relevant?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after discussion with the Design Team, we will leave this variation as it is for now. Some changes may occur in future tasks.

@orfium-sonarqube-app
Copy link

@kostasdano kostasdano merged commit 2c7e89d into feat/NDS-701_textfields_v5 Sep 12, 2023
@kostasdano kostasdano deleted the feat/NDS-792_date_picker_leftovers branch September 12, 2023 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants