Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NDS-785] date picker UI changes [v5] #665

Merged
merged 14 commits into from
Sep 7, 2023
Merged

[NDS-785] date picker UI changes [v5] #665

merged 14 commits into from
Sep 7, 2023

Conversation

kostasdano
Copy link
Collaborator

@kostasdano kostasdano commented Sep 5, 2023 •
edited
Loading

Description

NDS-785

This PR includes:

  • all necessary UI changes for the OverlayComponent for DatePicker and DateRangePicker,
  • date and dateTime tokens
  • update stories and tests (some tests are skipped and will be fixed on next PR)
  • make options optional through a new prop

@kostasdano kostasdano marked this pull request as ready for review September 5, 2023 13:39
@kostasdano kostasdano requested a review from a team as a code owner September 5, 2023 13:39
panvourtsis
panvourtsis reviewed Sep 6, 2023
View reviewed changes
Copy link
Collaborator

@panvourtsis panvourtsis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also check sonarqube online for the failed one

src/components/DatePicker/DatePicker.stories.mdx Show resolved Hide resolved
src/components/DatePicker/index.ts Show resolved Hide resolved
@orfium-sonarqube-app
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

92.5% 92.5% Coverage
0.0% 0.0% Duplication

panvourtsis
panvourtsis approved these changes Sep 7, 2023
View reviewed changes
Copy link
Collaborator

@panvourtsis panvourtsis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool job 👏

@kostasdano kostasdano merged commit faa1f89 into feat/NDS-701_textfields_v5 Sep 7, 2023
@kostasdano kostasdano deleted the feat/NDS-785_date_picker_ui_changes branch September 7, 2023 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@panvourtsis panvourtsis panvourtsis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kostasdano @panvourtsis