Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

List of V5 #655

Merged
merged 15 commits into from
Jul 31, 2023
Merged

List of V5 #655

merged 15 commits into from
Jul 31, 2023

Conversation

panvourtsis
Copy link
Collaborator

Description

[Pending] is the latest tokens for it

This PR introduces the new List component. The new List consists of 5 components

  • <List>
  • <ListItemSection>
  • <ListItem>
  • <ListItemAction>
  • <ListItemText>

With the new List we will be able to be flexible in other components as well like menu, select etc

Screenshot

Test Plan

@panvourtsis panvourtsis requested a review from a team as a code owner July 27, 2023 12:35
@panvourtsis panvourtsis changed the base branch from feat/NDS-701_textfields_v5 to feat/NDS-703-select_v5 July 27, 2023 12:41
@panvourtsis panvourtsis requested a review from kostasdano July 31, 2023 09:46
@orfium-sonarqube-app
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 6 Code Smells

89.9% 89.9% Coverage
0.0% 0.0% Duplication

kostasdano
kostasdano approved these changes Jul 31, 2023
View reviewed changes
Copy link
Collaborator

@kostasdano kostasdano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work 🎉

@panvourtsis panvourtsis merged commit 392e85a into feat/NDS-703-select_v5 Jul 31, 2023
@panvourtsis panvourtsis deleted the feat/list-v5 branch July 31, 2023 13:15
@panvourtsis panvourtsis mentioned this pull request Aug 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kostasdano kostasdano kostasdano approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@panvourtsis @kostasdano