Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NDS-705] NumberField [v5] #649

Merged
merged 7 commits into from
Jul 27, 2023
Merged

[NDS-705] NumberField [v5] #649

merged 7 commits into from
Jul 27, 2023

Conversation

kostasdano
Copy link
Collaborator

@kostasdano kostasdano commented Jul 20, 2023 •
edited by jira bot
Loading

Description

NDS-705

@kostasdano kostasdano marked this pull request as ready for review July 20, 2023 13:14
@kostasdano kostasdano requested a review from a team as a code owner July 20, 2023 13:14
@panvourtsis
Copy link
Collaborator

can we make another PR where all forms are as Figma?

Fields

  • Number Field
  • Text Field
    etc

@orfium-sonarqube-app
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

93.0% 93.0% Coverage
0.0% 0.0% Duplication

@kostasdano kostasdano requested a review from panvourtsis July 27, 2023 07:08
panvourtsis
panvourtsis approved these changes Jul 27, 2023
View reviewed changes
Copy link
Collaborator

@panvourtsis panvourtsis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job well done 🍰 !

@kostasdano kostasdano merged commit be1d40c into feat/NDS-701_textfields_v5 Jul 27, 2023
@kostasdano kostasdano deleted the feat/NDS-705_number_field_v5 branch July 27, 2023 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@panvourtsis panvourtsis panvourtsis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kostasdano @panvourtsis