Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NDS-702] TextField [v5] #638

Merged
merged 10 commits into from
Jun 30, 2023

Conversation

kostasdano
Copy link
Collaborator

@kostasdano kostasdano commented Jun 26, 2023

Description

NDS-702

  • Make TextField and MultiTextField controlled.
  • Apply all UI changes for TextField and MultiTextField according to v5 Designs.
  • Remove unecessary props (prefix)
  • Label is now required and optionally combined with placeholder

@panvourtsis panvourtsis marked this pull request as ready for review June 26, 2023 11:00
@panvourtsis panvourtsis requested a review from a team as a code owner June 26, 2023 11:00
@panvourtsis panvourtsis reopened this Jun 26, 2023
@panvourtsis panvourtsis reopened this Jun 27, 2023
Copy link
Collaborator

@panvourtsis panvourtsis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other than the small things that i found, the work that you have done here is amazing, kudos 🎊

src/components/TextField/TextField.tsx Outdated Show resolved Hide resolved
src/components/TextField/TextField.tsx Show resolved Hide resolved
src/components/TextInputBase/TextInputBase.tsx Outdated Show resolved Hide resolved
src/components/TextField/TextField.tsx Show resolved Hide resolved
src/components/MultiTextFieldBase/MultiTextFieldBase.tsx Outdated Show resolved Hide resolved
src/components/TextField/TextField.tsx Show resolved Hide resolved
src/components/TextField/TextField.tsx Show resolved Hide resolved

<Preview>
<Story name="Text Field with Icons">
<Story name="TextField with Icons">
<Stack>
<TextField
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one last thing i forgot is that each icons on the left or right must be aria-hidden={true}

@orfium-sonarqube-app
Copy link

@kostasdano kostasdano merged commit aed1fcb into feat/NDS-701_textfields_v5 Jun 30, 2023
@kostasdano kostasdano deleted the feat/NDS-702_new_textfield_v5 branch June 30, 2023 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants