Skip to content

Commit

Permalink
Merge pull request #659 from Orfium/fix/NDS-772_select_option_click_h…
Browse files Browse the repository at this point in the history
…andler_not_triggered
  • Loading branch information
kostasdano authored Aug 11, 2023
2 parents 2f82922 + 4554081 commit 44c45b8
Show file tree
Hide file tree
Showing 4 changed files with 19 additions and 7 deletions.
1 change: 1 addition & 0 deletions .storybook/preview.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -131,4 +131,5 @@ export const parameters = {
viewports: viewPorts,
},
options: { showPanel: true },
chromatic: { delay: 2000 },
};
7 changes: 1 addition & 6 deletions src/components/Chart/Chart.stories.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,7 @@ import DonutChartShowCase from '../storyUtils/DonutChartShowCase';
import { color } from './LineChart/story.utils';
import { initData } from './LineChart/mockedData';

<Meta
title="Design System/Chart"
parameters={{
chromatic: { delay: 2000 },
}}
/>
<Meta title="Design System/Chart" />

# LineChart

Expand Down
5 changes: 4 additions & 1 deletion src/components/Select/Select.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -310,8 +310,11 @@ const Select = React.forwardRef<HTMLInputElement, Props & InputProps & TestProps
const isEnter = event.key === 'Enter';

if (hasNoOptionsAndIsCreatable && isEnter) {
handleMultiSelectOptionClick(filteredOptions[0]);
const selectedOption = filteredOptions[0];

handleMultiSelectOptionClick(selectedOption);
setSearchValue('');
handleSelectedOption(selectedOption);
}
};

Expand Down
13 changes: 13 additions & 0 deletions src/components/Table/Table.stories.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,19 @@ import { Table } from '@orfium/ictinus';

<Props of={Table} />

### Disclaimer

In case of importing data produced using useMemo or external const, follow this pattern:

```js
import { Row } from '@orfium/ictinus/dist/components/Table/Table';
...
const data: Row<DataType> = useMemo(() => {}, []);
//or other types of data
```

Where Row is the type from the Table, so you must import it from there.

# Regular Table

Regular Table with simple rows
Expand Down

0 comments on commit 44c45b8

Please sign in to comment.