Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bad async usage in RecipeHarvester (Lombiq Technologies: OCORE-119) #13378

Merged
merged 3 commits into from
Mar 9, 2023
Merged

Fix bad async usage in RecipeHarvester (Lombiq Technologies: OCORE-119) #13378

merged 3 commits into from
Mar 9, 2023

Conversation

hishamco
Copy link
Member

@hishamco hishamco commented Mar 9, 2023

Fixes #10329

@hishamco hishamco force-pushed the hishamco/recipe-harvester branch from a0fa483 to 9c995b3 Compare March 9, 2023 13:52
@hishamco hishamco requested a review from Piedone March 9, 2023 15:37
@hishamco
Copy link
Member Author

hishamco commented Mar 9, 2023

@Piedone let me know if we need a unit test for this one

jtkech
jtkech approved these changes Mar 9, 2023
View reviewed changes
Copy link
Member

@jtkech jtkech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hishamco I approved it, I let you retry it

@hishamco hishamco merged commit f58eb2c into main Mar 9, 2023
@hishamco hishamco deleted the hishamco/recipe-harvester branch March 9, 2023 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtkech jtkech jtkech approved these changes

@Piedone Piedone Piedone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix bad async usage in RecipeHarvester
3 participants
@hishamco @Piedone @jtkech