This repository has been archived by the owner on Oct 14, 2024. It is now read-only.
Double-click/tap zoom #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 12 commits
October 13, 2015 13:37
ghost
|
|
||
| if ( constraint.zoomScale !== desiredZoomScale ) { | ||
|
|
||
| requestAnimationFrame( updateZoom ); |
There was a problem hiding this comment.
not fully sure about managing a separate requestAnimationFrame besides the global tick of orbitcontrols. We should also respect enableDamping to either animate or go to the desired state immediately
|
|
||
| if ( scope.enabled === false ) return; | ||
|
|
||
| if ( isDoubleClick( event ) === true ) { |
There was a problem hiding this comment.
I believe the doubletap can be initiated only after the touch state has been completed - after state = STATE.NONE;
There was a problem hiding this comment.
Do you mean this code block should be placed after state = STATE.NONE; ?
| @@ -429,6 +515,9 @@ module.exports = function(THREE) { | |||
|
|
|||
| var state = STATE.NONE; | |||
|
|
|||
| // for zoom toggle | |||
| var dollyDirection; | |||
added 2 commits
November 13, 2015 09:29
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.