Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swift: add MQTT client #254

Merged
merged 3 commits into from
Jan 8, 2025
Merged

Conversation

fsuc
Copy link
Member

@fsuc fsuc commented Dec 19, 2024

What's new

Add a implementation of a MQTT client with MQTT NIO


How to test

  1. Clone the its-client project.
  2. Run the MQTTNIOClientTests which use the MQTT client in different cases.

Closes #253

@fsuc fsuc added the Swift label Dec 19, 2024
@fsuc fsuc requested a review from pylapp December 19, 2024 16:28
@fsuc fsuc self-assigned this Dec 19, 2024
Copy link
Member

@pylapp pylapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Il va falloir que tu ajoutes une nouvelle entrée te concernant dans le fichier CONTRIBUTORS.md

Je me demande si, dans un éventuel README, on ne pourra pas par exemple préciser qu'il faille changer de broker MQTT si les tests échouent (i.e. passer de test.mosquitto.org à mqtt.eclipseprojects.io)

THIRD-PARTY.md Outdated Show resolved Hide resolved
@ymorin-orange
Copy link
Member

Il va falloir que tu ajoutes une nouvelle entrée te concernant dans le fichier CONTRIBUTORS.md
[...]

Please, stick to english. ;-)

@fsuc fsuc force-pushed the swift-add-mqtt-client branch from acfafdc to bcbfe71 Compare December 24, 2024 07:48
@ymorin-orange
Copy link
Member

@fsuc You need to sign-off your commits, too:

Signed-off-by: You NAME <your@email>

(weird that @pylapp did not spot that already! ;-))

@pylapp
Copy link
Member

pylapp commented Dec 24, 2024

@ymorin-orange I did not noticed anywhere the sign-off of commits were required (even if in the open source governance side we strongly recommend to use it, that's not mandatory yet) 😅
However I did not look for any files mentioning it 😅

@ymorin-orange
Copy link
Member

@ymorin-orange I did not noticed anywhere the sign-off of commits were required (even if in the open source governance side we strongly recommend to use it, that's not mandatory yet) 😅
However I did not look for any files mentioning it 😅

@pylapp It was my understanding that it was required; you even once warned me about it for other contributions elsewhere... :-p

Anyway, as you say it is strongly recommended, I'd suggest we do use it.

Besides, all the other contributors do use sign-offs, as can be seen by simply running git log (although some relatively recent newcomers may forget adding it from time to time). ;-)

@pylapp
Copy link
Member

pylapp commented Dec 24, 2024

Yep I agree. It could be interesting to define a kind of DEVELOP or CONTRIBUTING file to talk about for example DCO and uses of forks to contribute 😁

@ymorin-orange
Copy link
Member

Yep I agree. It could be interesting to define a kind of DEVELOP or CONTRIBUTING file to talk about for example DCO and uses of forks to contribute 😁

Be my guest! ;-p

fsuc added 3 commits December 24, 2024 12:47
Add a protocol MQTTClient with an implementation based on MQTT NIO

Signed-off-by: François Suc <[email protected]>
Signed-off-by: François Suc <[email protected]>
Signed-off-by: François Suc <[email protected]>
@fsuc fsuc force-pushed the swift-add-mqtt-client branch from bcbfe71 to 4b21c7c Compare December 24, 2024 13:13
Copy link
Member

@pylapp pylapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pylapp pylapp merged commit 12bed74 into Orange-OpenSource:master Jan 8, 2025
58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add MQTT client
4 participants