-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
swift: add MQTT client #254
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Il va falloir que tu ajoutes une nouvelle entrée te concernant dans le fichier CONTRIBUTORS.md
Je me demande si, dans un éventuel README, on ne pourra pas par exemple préciser qu'il faille changer de broker MQTT si les tests échouent (i.e. passer de test.mosquitto.org à mqtt.eclipseprojects.io)
Please, stick to english. ;-) |
acfafdc
to
bcbfe71
Compare
@ymorin-orange I did not noticed anywhere the sign-off of commits were required (even if in the open source governance side we strongly recommend to use it, that's not mandatory yet) 😅 |
@pylapp It was my understanding that it was required; you even once warned me about it for other contributions elsewhere... :-p Anyway, as you say it is strongly recommended, I'd suggest we do use it. Besides, all the other contributors do use sign-offs, as can be seen by simply running |
Yep I agree. It could be interesting to define a kind of DEVELOP or CONTRIBUTING file to talk about for example DCO and uses of forks to contribute 😁 |
Be my guest! ;-p |
Add a protocol MQTTClient with an implementation based on MQTT NIO Signed-off-by: François Suc <[email protected]>
Signed-off-by: François Suc <[email protected]>
Signed-off-by: François Suc <[email protected]>
bcbfe71
to
4b21c7c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What's new
Add a implementation of a MQTT client with MQTT NIO
How to test
Closes #253