Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable JUnit reports in CI #345

Closed
wants to merge 2 commits into from
Closed

Enable JUnit reports in CI #345

wants to merge 2 commits into from

Conversation

atcol
Copy link

@atcol atcol commented Nov 8, 2021

No description provided.

@lepapareil lepapareil marked this pull request as draft November 10, 2021 09:53
@lepapareil lepapareil added this to the 1.5.0 milestone Nov 12, 2021
@lepapareil lepapareil added the ci label Nov 12, 2021
@lepapareil
Copy link
Collaborator

Hi @atcol, it seems that the junit report publish is not working ?

image

@lepapareil lepapareil removed this from the 1.5.0 milestone Nov 12, 2021
@lepapareil lepapareil removed the ci label Nov 12, 2021
@atcol
Copy link
Author

atcol commented Nov 13, 2021

Is this a token issue? See mikepenz/action-junit-report-legacy#32

@lepapareil
Copy link
Collaborator

Is this a token issue? See mikepenz/action-junit-report-legacy#32

It seems that the token is not readable in a pull request when actions are triggered from a fork.
However i forked your fork, i have created a full local pull request, and the result is as expected.
I will do some more checks from last fetched master branch and will validate it with @fabricereix 😄.

@lepapareil lepapareil self-assigned this Nov 15, 2021
@lepapareil
Copy link
Collaborator

Hi @atcol,

Finally the junit report action doesn't give us much on our ci. Indeed we already have the errors details in jobs console output, moreover we have false positives in checks because of the real errors testing.

image

That's why we should not integrate the junit action for the moment.

@lepapareil lepapareil closed this Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants