feat: add connect-timeout option per request #3306
Open
+26
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zikani03
force-pushed
the
3163-connect-timeout-per-request
branch
from
59036a9
to
cbbf1ae
Compare
|
Hi @zikani03 don't worry about the failed pipelines, we have some issues to fix on it, I will ping you when evrything comes back to normal 😔 |
|
/rebase |
|
🕗 /rebase is running, please wait for completion. |
Added a connect-timeout option to allow users to specify a connect-timeout for each request in a hurl file. Closes Orange-OpenSource#3163
hurl-bot
force-pushed
the
3163-connect-timeout-per-request
branch
from
cbbf1ae
to
a3e9b1a
Compare
|
Hi @zikani03, all issues have been fixed on ci, you can rely on the pipelines once again 😀. |
|
Hi @zikani03 you need to do some modifications (the CI/CD has failed because some new branch code is not coverered in What you need to do:
The CI/CD should be OK after that, Thanks ! |
|
Hi @jcamiel , thanks for the direction - I have updated the hurlfmt test files, also added the option to the hurl.grammar |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a connect-timeout option to allow users to specify a connect-timeout for each request in a hurl file.
Closes #3163