Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(guidelines): drop design guidelines content and replace it with a simpler page #960

Merged
merged 50 commits into from
Dec 14, 2021

Conversation

julien-deramond
Copy link
Contributor

@julien-deramond julien-deramond commented Dec 6, 2021

louismaximepiton and others added 24 commits December 7, 2021 15:19
Signed-off-by: louismaximepiton <[email protected]>
Signed-off-by: louismaximepiton <[email protected]>
Signed-off-by: louismaximepiton <[email protected]>
Signed-off-by: louismaximepiton <[email protected]>
Signed-off-by: louismaximepiton <[email protected]>
Signed-off-by: louismaximepiton <[email protected]>
Signed-off-by: louismaximepiton <[email protected]>
Signed-off-by: louismaximepiton <[email protected]>
Signed-off-by: louismaximepiton <[email protected]>
Signed-off-by: louismaximepiton <[email protected]>
Signed-off-by: louismaximepiton <[email protected]>
.
Signed-off-by: louismaximepiton <[email protected]>
Signed-off-by: louismaximepiton <[email protected]>
…-guidelines-content-lmp

Some drops on guidelines
Signed-off-by: louismaximepiton <[email protected]>
Signed-off-by: louismaximepiton <[email protected]>
Signed-off-by: louismaximepiton <[email protected]>
Signed-off-by: louismaximepiton <[email protected]>
Signed-off-by: louismaximepiton <[email protected]>
@louismaximepiton louismaximepiton marked this pull request as ready for review December 13, 2021 10:35
@julien-deramond
Copy link
Contributor Author

julien-deramond commented Dec 14, 2021

@isabellechanclou @louismaximepiton Some thoughts about the cards (not to do here but with a dedicated issue to create):

  • Create specific classes for the developers in order to use the 3 authorized sizes: Large (460px), Medium (300px) and Small (220px). Something like .card-sm and .card-lg (medium size being the default size like the buttons).
  • Let in the documentation all the parts regarding the ways of dealing with the sizes but precise that the recommended sizes are the larger, medium and small
  • Display the 3 sizes in the examples
  • Only use the medium size in the examples for all the examples
  • Check the rendering and compare it to the design specs. I've spotted some inconsistencies: height of the area when there is only a title for example
  • Maybe use shortcodes to avoid copy/pasting in the examples page

@julien-deramond
Copy link
Contributor Author

We should check .github/workflows.percy.yml and how it works. I can see flags: "--snapshot-files ./docs/5.1/guidelines/**/*.html,./docs/5.1/examples/cheatsheet/index.html,./docs/5.1/examples/cheatsheet-rtl/index.html". Since we won't have the components anymore in "/guidelines" and that the 2 cheatsheet examples are hidden.

@julien-deramond julien-deramond merged commit 46b54a8 into main Dec 14, 2021
@julien-deramond julien-deramond deleted the main-jd-replace-design-guidelines-content branch December 14, 2021 13:13
@julien-deramond julien-deramond mentioned this pull request Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop "Design guidelines" content from documentation
3 participants