Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global Headers (all) #727

Closed
wants to merge 64 commits into from
Closed

Global Headers (all) #727

wants to merge 64 commits into from

Conversation

klediouron
Copy link
Contributor

@klediouron klediouron commented Jul 5, 2021

#702 #703 #704 #705 #706 #707 #708 #709 #710

This pull request contains every global headers (Global Headers, OBS headers)

Preview:


DoD

Development

  • Should match specs (eg. either the Web UI Kit or any pattern from the WAI — or both…)
  • Docs added:
    • including the "Sass" part using scss-docs shortcode
    • in /about/overview/#custom-components if it is a new Orange custom component
    • in /getting-started/introduction/#components if it is a new Orange custom component that requires JavaScript (and Popper)
    • in /customize/overview#csps-and-embedded-svgs if it is a new Orange custom component that includes embedded SVGs in our CSS
    • in /forms/validation/?#supported-elements if it is a new Orange custom component that is a form control
    • in /forms/overview/ if it is a new Orange custom component that is a form control
  • Check (and fix) RTL version
  • Run linters
  • Run compilers
  • Tests added for JS-side
  • Run tests
  • Manually run BrowserStack test
  • Manually run Percy test
  • Cross-browser test:
    • Firefox ESR
    • Latest Edge, Chrome, Firefox, Safari
    • iOS Safari
    • Chrome & Firefox on Android
  • Clean up the branch using rebase -i
  • Commited with feat(…): … message
  • Mention it in Migration Guide (if back-from-v4): renamed variables, changes in markup requirement, etc.

Reviews

  • Code review
  • A11y review
  • Design review

@klediouron klediouron linked an issue Jul 5, 2021 that may be closed by this pull request
@klediouron klediouron force-pushed the feature/global-header-710 branch 9 times, most recently from 61bbd92 to 4297726 Compare September 10, 2021 09:55
@klediouron klediouron changed the title OBS global header standard with navigation bar Global Headers (all) Sep 13, 2021
@julien-deramond julien-deramond added v5 and removed v5 labels Sep 15, 2021
@klediouron klediouron added v5 and removed v5 labels Sep 15, 2021
@klediouron

This comment was marked as resolved.

@klediouron klediouron force-pushed the feature/global-header-710 branch from 4f08630 to b02db03 Compare September 29, 2021 12:55
@klediouron klediouron force-pushed the feature/global-header-710 branch 9 times, most recently from bf3eb73 to 9edf151 Compare October 13, 2021 08:58
@klediouron klediouron force-pushed the feature/global-header-710 branch from ac0ddc4 to 0a8fd4f Compare February 9, 2022 14:41
@louismaximepiton louismaximepiton force-pushed the feature/global-header-710 branch from aa098f1 to c0084bd Compare February 9, 2022 16:07
@klediouron klediouron force-pushed the feature/global-header-710 branch from e944517 to f48b703 Compare February 11, 2022 10:00
@louismaximepiton louismaximepiton force-pushed the feature/global-header-710 branch from f48b703 to e944517 Compare February 11, 2022 10:03
@klediouron klediouron force-pushed the feature/global-header-710 branch from 0e45922 to 65a540f Compare February 11, 2022 14:27
@louismaximepiton louismaximepiton force-pushed the feature/global-header-710 branch from 65a540f to 0e45922 Compare February 11, 2022 14:28
@klediouron
Copy link
Contributor Author

klediouron commented Feb 14, 2022

WIP : moving all changes into a new branch feature/global-headers starting from the current state of main.

Closed to #1099.

@louismaximepiton louismaximepiton mentioned this pull request Feb 14, 2022
16 tasks
@julien-deramond julien-deramond deleted the feature/global-header-710 branch July 17, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment