Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Stepped Process: add the component from v4 #636

Merged
merged 1 commit into from
Feb 26, 2021

Conversation

klediouron
Copy link
Contributor

@klediouron klediouron commented Feb 19, 2021

Stepbar is being ported into v5 as "stepped process" component.

Everything has been adapted according to this change


Closes #524


  • Should match specs (eg. either the Web UI Kit or any pattern from the WAI — or both…)
  • Docs added:
    • including the "Sass" part using scss-docs shortcode
    • in Design Guidelines probably
    • in Cheatsheet / Cheatsheet RTL examples
  • Check (and fix) RTL version
    • Beware of clip-path in RTL, which would need some attention—and maybe the loop setting z-index too, might even be dropped?
  • Run linters
  • Run compilers
  • Run tests
  • Cross-browser test:
    • Firefox ESR
    • Latest Edge, Chrome, Firefox, Safari
    • iOS Safari
    • Chrome & Firefox on Android
  • Clean up the branch using rebase -i
  • Commited with feat(…): … message
  • Mention it
    • in Ship List
    • in Migration Guide (if back-from-v4): renamed variables, changes in markup requirement, etc.

@klediouron klediouron requested a review from ffoodd February 19, 2021 09:02
@klediouron klediouron force-pushed the feature/stepped-process branch 3 times, most recently from f4fe8c3 to c48683f Compare February 19, 2021 10:48
@ffoodd ffoodd added this to the 5.0.0-beta milestone Feb 19, 2021
site/content/docs/5.0/components/stepped-process.md Outdated Show resolved Hide resolved
site/content/docs/5.0/components/stepped-process.md Outdated Show resolved Hide resolved
site/content/docs/5.0/components/stepped-process.md Outdated Show resolved Hide resolved
site/content/docs/5.0/components/stepped-process.md Outdated Show resolved Hide resolved
scss/_stepped-process.scss Outdated Show resolved Hide resolved
scss/_stepped-process.scss Outdated Show resolved Hide resolved
scss/_stepped-process.scss Outdated Show resolved Hide resolved
scss/_stepped-process.scss Outdated Show resolved Hide resolved
@klediouron klediouron force-pushed the feature/stepped-process branch from 1c3fe60 to be5b5d9 Compare February 19, 2021 15:37
@ffoodd
Copy link
Contributor

ffoodd commented Feb 22, 2021

New side topic here, now that we merged main recently: add a "Sass# part in the docs, using the scss-docs shortcode to display at least variables.

@klediouron klediouron force-pushed the feature/stepped-process branch from 5486d9c to 4462e53 Compare February 22, 2021 10:25
scss/_variables.scss Outdated Show resolved Hide resolved
scss/_variables.scss Outdated Show resolved Hide resolved
@klediouron klediouron force-pushed the feature/stepped-process branch 2 times, most recently from 2a8426f to 2204d14 Compare February 25, 2021 09:46
scss/_variables.scss Show resolved Hide resolved
site/content/docs/5.0/examples/cheatsheet-rtl/index.html Outdated Show resolved Hide resolved
site/content/docs/5.0/examples/cheatsheet-rtl/index.html Outdated Show resolved Hide resolved
site/data/sidebar.yml Outdated Show resolved Hide resolved
@ffoodd
Copy link
Contributor

ffoodd commented Feb 26, 2021

Design

From my first understanding, the design published in Zeplin uses a smaller font-size (my guess: .875rem) and probably smaller vertical padding too, since the bar is only 30px tall on Zeplin and 38px in Boosted.

Improvements

Also the intermediary display (between sm and lg), the last item does not have enough space. Here's my recommendation:

  • drop the &:last-child part L80 that sets padding-right
  • drop max-width on ..stepped-process-item (L69, L96, L118)
  • add an exception for the .active item between sm and lg breakpoints:
@include media-breakpoint-between('sm', 'lg') {
  .stepped-process-item.active {
    flex: $stepped-process-max-items - 1;
  }
}

This should output flex: 4 with the current settings — and we only rely on flexbox. 🎉

Docs

  • In the guidelines, please tend to re-use UI Kit / Zeplin's wording for your examples, in order to match as much as possible the UI Kit. So your items should be "Sign in", "Review", Delivery", "*Payment", "Place order".
  • In cheatsheets, please stick to alphabetical order (in english) to add a new component's link in the sidebar: your "Stepped process" link is a bit lost for now :D

@klediouron klediouron force-pushed the feature/stepped-process branch 2 times, most recently from 89ce729 to f059e6d Compare February 26, 2021 13:34
scss/_stepped-process.scss Outdated Show resolved Hide resolved
@klediouron klediouron force-pushed the feature/stepped-process branch 3 times, most recently from 06ae9c7 to 6390593 Compare February 26, 2021 14:44
scss/_variables.scss Outdated Show resolved Hide resolved
@klediouron klediouron force-pushed the feature/stepped-process branch from 6390593 to 862e77d Compare February 26, 2021 14:56
@klediouron klediouron merged commit 2f353e3 into v5-dev Feb 26, 2021
@klediouron klediouron deleted the feature/stepped-process branch February 26, 2021 15:09
@ffoodd ffoodd linked an issue Mar 4, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stepped process (v4:stepbar)
2 participants