-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Storybook to the project #565
Conversation
This comment has been minimized.
This comment has been minimized.
1d2e025
to
8ea5185
Compare
8ea5185
to
b9c8b02
Compare
This comment has been minimized.
This comment has been minimized.
ℹ️ This comment will help me to track what I'm doing to try to connect Zeplin and Storybook.
|
ℹ️ This comment will help me to track what I'm doing to try to connect ZeroHeight and the rest of the World.
|
47692b7
to
43e02ca
Compare
So after a few tries:
So as of now, Chromatic isn't needed and might be ignored if its design-collaboration features don't get GDL attention. Note for future self:
|
If/when IOT-Map-Component gets linked to Boosted in any way, Storybook composition might be welcome. |
Just for info, I've modified the Zeroheight page used in this PR to embed Storybook components now deployed in Netflify (instead of Chromatic - dropped): https://zeroheight.com/7183633e4/p/18af52-alerts-netlify. |
This comment has been minimized.
This comment has been minimized.
608c7f5
to
e33ea41
Compare
289d9a3
to
9e391bd
Compare
This comment was marked as resolved.
This comment was marked as resolved.
1627c26
to
61cafc9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the Hash of boosted.css
and boosted.bundle.js
are the same between main branch and this one. Do I need to chack all of them ?
We don't have any images like logos, or icons/images in localhost.
The changes seem to be great, but I have several questions before merging.
"@storybook/addon-a11y", | ||
"@storybook/addon-links", | ||
{ | ||
name: "@storybook/addon-essentials", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need all of them ? (array)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably not but too much to investigate right now. I'll put it in the issue created after the merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, let's try it
4ae10b5
to
939052e
Compare
cafdd6b
to
4409030
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Closes #563
Preview: https://deploy-preview-565--boosted.netlify.app/storybook/
To-do
High priority
Mention Storybook somewhere in our docs? Is that useful at all?Medium priority
KnobsIntegration
Default Storybook configuration created like this:
How to test
Dropped
Chromatic
Was setup for deployment convenience, but replaced with Storybook static build + Hugo mounts.