Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OUDS] Fix(docs): broken links to /blob/vx.y.z-ouds-web files #2647

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

julien-deramond
Copy link
Contributor

@julien-deramond julien-deramond commented Jul 24, 2024

Description

This PR fixes some broken links due to the fact that our tags have a "-ouds-web" suffix.

Types of change

  • Bug fix (non-breaking which fixes an issue)

Live previews

@julien-deramond julien-deramond added docs Improvements or additions to documentation fix labels Jul 24, 2024
@julien-deramond julien-deramond added this to the OUDS milestone Jul 24, 2024
Copy link

netlify bot commented Jul 24, 2024

Deploy Preview for boosted ready!

Name Link
🔨 Latest commit 1521db7
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/66a0e3de2b39630008f0ced6
😎 Deploy Preview https://deploy-preview-2647--boosted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@julien-deramond julien-deramond marked this pull request as ready for review July 24, 2024 11:25
@julien-deramond julien-deramond changed the title fix(docs): broken links to /blob/vx.y.z-ouds-web files fix(docs): broken links to /blob/vx.y.z-ouds-web files Jul 24, 2024
@julien-deramond julien-deramond changed the title fix(docs): broken links to /blob/vx.y.z-ouds-web files [OUDS] Fix(docs): broken links to /blob/vx.y.z-ouds-web files Jul 24, 2024
Copy link
Member

@louismaximepiton louismaximepiton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 👌 Do you think they well be removed somehow once the OUDS Web lib will be the main one ? If yes, maybe we should add a parameter to handle this rather than changing the link directly.

@julien-deramond
Copy link
Contributor Author

Do you think they well be removed somehow once the OUDS Web lib will be the main one ?

The only moment when we would be able to remove the suffix, is when the major version of OUDS Web will be way over 6/7/8 to not block Boosted tags (that will follow Bootstrap tags).

@julien-deramond julien-deramond merged commit 9ec5f54 into ouds/main Jul 24, 2024
19 checks passed
@louismaximepiton louismaximepiton deleted the ouds/main-jd-fix-broken-links branch July 30, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation fix
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants