feat(footer): use h2+h3 in footer instead of h1+h2

Orange-OpenSource · Dec 13, 2019 · 0cb93ad · 0cb93ad
1 parent 1d73579
commit 0cb93ad
Show file tree

Hide file tree

Showing 7 changed files with 67 additions and 67 deletions.
diff --git a/scss/_o-footer.scss b/scss/_o-footer.scss
@@ -41,7 +41,7 @@
       margin-bottom: map-get($spacers, 2);
     }
 
-    h2 {
+    h3 {
       margin-top: map-get($spacers, 2);
       font-size: $font-size-sm;
     }

diff --git a/site/_includes/boostwatch/ofooter.html b/site/_includes/boostwatch/ofooter.html
@@ -1,6 +1,6 @@
 <h2 id="footer">Footer<a class="doc-link d-inline-flex align-items-center ml-2" href="../components/orange-footer/" title="go to footer documentation page"></a></h2>
 <footer class="o-footer" role="contentinfo">
-    <h1 class="sr-only">footer - site map & informations</h1>
+    <h2 class="sr-only">Site map & informations</h2>
     <div class="o-footer-top">
         <div class="container-fluid">
             <div class="row">
@@ -14,7 +14,7 @@ <h1 class="sr-only">footer - site map & informations</h1>
         <div class="container-fluid">
             <div class="row">
                 <div class="col-md-3 col-sm-6">
-                    <h2>Discover</h2>
+                    <h3>Discover</h3>
                     <ul class="nav flex-column">
                         <li class="nav-item"><a class="nav-link" href="#">Unde omnis istea</a></li>
                         <li class="nav-item"><a class="nav-link" href="#">Natus error sit</a></li>
@@ -23,7 +23,7 @@ <h2>Discover</h2>
                     </ul>
                 </div>
                 <div class="col-md-3 col-sm-6">
-                    <h2>Shop</h2>
+                    <h3>Shop</h3>
                     <ul class="nav flex-column">
                         <li class="nav-item"><a class="nav-link" href="#">Natus error sit</a></li>
                         <li class="nav-item"><a class="nav-link" href="#">Unde omnis istea</a></li>
@@ -33,14 +33,14 @@ <h2>Shop</h2>
                     </ul>
                 </div>
                 <div class="col-md-3 col-sm-6">
-                    <h2>Services</h2>
+                    <h3>Services</h3>
                     <ul class="nav flex-column">
                         <li class="nav-item"><a class="nav-link" href="#">Doloremque</a></li>
                         <li class="nav-item"><a class="nav-link" href="#">Totam rem aperiam</a></li>
                     </ul>
                 </div>
                 <div class="col-md-3 col-sm-6">
-                    <h2>Support</h2>
+                    <h3>Support</h3>
                     <ul class="nav flex-column">
                         <li class="nav-item"><a class="nav-link" href="#">Doloremque</a></li>
                         <li class="nav-item"><a class="nav-link" href="#">Unde omnis istea</a></li>

diff --git a/site/_includes/footer.html b/site/_includes/footer.html
@@ -1,5 +1,5 @@
 <footer class="o-footer mt-0" role="contentinfo">
-  <h1 class="sr-only">footer - site map & informations</h1>
+  <h2 class="sr-only"Site map & informations</h2>
   <div class="o-footer-body py-3 px-0">
     <div class="container-fluid">
       <p class="m-0">This documentation is an adaptation made by Orange</p>

diff --git a/site/docs/4.4/components/orange-footer.md b/site/docs/4.4/components/orange-footer.md
@@ -17,7 +17,7 @@ According to the brand, Orange footer has black background and white text color.
 
 {% capture example %}
 <footer class="o-footer" role="contentinfo">
-    <h1 class="sr-only">Site map & informations</h1>
+    <h2 class="sr-only">Site map & informations</h2>
     <div class="o-footer-top">
         <div class="container">
             <div class="row mb-0">
@@ -40,7 +40,7 @@ According to the brand, Orange footer has black background and white text color.
         <div class="container">
             <div class="row">
                 <div class="col-md-3 col-sm-6">
-                    <h2>Discover</h2>
+                    <h3>Discover</h3>
                     <ul class="nav flex-column">
                         <li class="nav-item"><a class="nav-link" href="#">Unde omnis istea</a></li>
                         <li class="nav-item"><a class="nav-link" href="#">Natus error sit</a></li>
@@ -49,7 +49,7 @@ According to the brand, Orange footer has black background and white text color.
                     </ul>
                 </div>
                 <div class="col-md-3 col-sm-6">
-                    <h2>Shop</h2>
+                    <h3>Shop</h3>
                     <ul class="nav flex-column">
                         <li class="nav-item"><a class="nav-link" href="#">Natus error sit</a></li>
                         <li class="nav-item"><a class="nav-link" href="#">Unde omnis istea</a></li>
@@ -59,14 +59,14 @@ According to the brand, Orange footer has black background and white text color.
                     </ul>
                 </div>
                 <div class="col-md-3 col-sm-6">
-                    <h2>Services</h2>
+                    <h3>Services</h3>
                     <ul class="nav flex-column">
                         <li class="nav-item"><a class="nav-link" href="#">Doloremque</a></li>
                         <li class="nav-item"><a class="nav-link" href="#">Totam rem aperiam</a></li>
                     </ul>
                 </div>
                 <div class="col-md-3 col-sm-6">
-                    <h2>Support</h2>
+                    <h3>Support</h3>
                     <ul class="nav flex-column">
                         <li class="nav-item"><a class="nav-link" href="#">Doloremque</a></li>
                         <li class="nav-item"><a class="nav-link" href="#">Unde omnis istea</a></li>
-Original file line number
+Diff line change
@@ Expand Up / @@ -41,7 +41,7 @@ @@
           margin-bottom: map-get($spacers, 2);
         }
-        h2 {
+        h3 {
           margin-top: map-get($spacers, 2);
           font-size: $font-size-sm;
         }
@@ Expand Down @@