Skip to content
This repository has been archived by the owner on Dec 13, 2023. It is now read-only.

Missing track fields in metadataChanged message #14

Closed
david-luksch-nangu opened this issue Jun 29, 2018 · 1 comment
Closed

Missing track fields in metadataChanged message #14

david-luksch-nangu opened this issue Jun 29, 2018 · 1 comment
Assignees

Comments

@david-luksch-nangu
Copy link

I didn't find any mention of some track fields being optional in OCast protocol v1.9 description, but metadataChanged message has some fields missing for audio tracks (and video, too).

E.g. when I cast a video:

{
  "dst": "browser",
  "src": "0e528c71-5163-445c-8bbe-ae67533e2786",
  "type": "command",
  "id": 1,
  "message": {
    "service": "org.ocast.media",
    "data": {
      "options": {
        
      },
      "name": "prepare",
      "params": {
        "url": "https://sales-ssl-streamer.nangu.tv:8485/126-pc.mpd",
        "frequency": 1,
        "title": "Dead cast entity 1",
        "subtitle": "Test entity for non-linear DASH playback",
        "logo": "https://placeholder.com",
        "mediaType": "video",
        "transferMode": "streamed",
        "autoplay": true
      }
    }
  }
}

the next metadataChanged message looks like this:

{
  "name": "metadataChanged",
  "options": null,
  "params": {
    "title": "Dead cast entity 1",
    "subtitle": "Test entity for non-linear DASH playback",
    "logo": "https://placeholder.com",
    "mediaType": "video",
    "transferMode": "streamed",
    "textTracks": [
      {
        "type": "text",
        "trackId": "0",
        "enabled": false,
        "language": "",
        "label": "Shaka Player TextTrack"
      }
    ],
    "audioTracks": [
      {
        "type": "audio",
        "trackId": "0"
      }
    ],
    "videoTracks": [
      {
        "type": "video",
        "trackId": "0"
      }
    ]
  }
}

Since enabled, language and label fields are missing completely and OCast-Java assumes (in compliance with the protocol) that the fields are required, it fails to process the message.

Thank you,
David

@juliendelage
Copy link
Contributor

fixed in v1.0.7

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants