Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow user to move Palettes to Trash/Recycle Bin instead of deleting them permanently #914

Merged
merged 7 commits into from
Oct 11, 2023
Merged

Allow user to move Palettes to Trash/Recycle Bin instead of deleting them permanently #914

merged 7 commits into from
Oct 11, 2023

Conversation

Variable-ind
Copy link
Contributor

@Variable-ind Variable-ind commented Oct 8, 2023 •
edited by OverloadedOrama
Loading

Some additional changes that I thought be added to this pull request.

  1. Fix deleted signal emitted wrongly

    • it was written as deleted.emit(deleted) which did not seem to be working so i changed it to deleted.emit()

  2. Fix create and edit palette dialog UI

    • Dialog titles of CreatePaletteDialog.tscn and EditPaletteDialog.tscn
    • Label Autowrap and alignment to match how they were in v0.11.2 (In CreatePaletteDialog.tscn and EditPaletteDialog.tscn)
    • a minor ui change in EditPaletteDialog.tscn that allows comment to expand vertically

  3. fix path nodes renamed to path3d by godot project converter

    • ReferenceImageButton.tscn and EditPaletteDialog.tscn

@Variable-ind Variable-ind changed the title move paletes to bin instead of deleting them permanently move palettes to bin instead of deleting them permanently Oct 9, 2023
Variable-ind added a commit to Variable-ind/Pixelorama that referenced this pull request Oct 9, 2023
@Variable-ind
backport Orama-Interactive#914
d32d6a4 
move palettes to bin instead of deleting them permanently
@OverloadedOrama OverloadedOrama changed the title move palettes to bin instead of deleting them permanently Move palettes to trashbin instead of deleting them permanently Oct 9, 2023
@OverloadedOrama OverloadedOrama mentioned this pull request Oct 9, 2023
Merged
@Variable-ind Variable-ind marked this pull request as draft October 9, 2023 10:16
@Variable-ind Variable-ind changed the title Move palettes to trashbin instead of deleting them permanently Allow user to move Palettes to Trash/Recycle Bin instead of deleting them permanently Oct 9, 2023
@Variable-ind Variable-ind marked this pull request as ready for review October 9, 2023 11:35
OverloadedOrama
OverloadedOrama approved these changes Oct 11, 2023
View reviewed changes
Copy link
Member

@OverloadedOrama OverloadedOrama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you!

@OverloadedOrama OverloadedOrama merged commit fd5adef into Orama-Interactive:master Oct 11, 2023
3 of 4 checks passed
OverloadedOrama pushed a commit that referenced this pull request Oct 11, 2023
@Variable-ind
[0.x] Allow user to move Palettes to Trash/Recycle Bin instead of del…
7416ed3 
…eting them permanently (#918)

* backport #914

move palettes to bin instead of deleting them permanently

* update backport to use dialog
@Variable-ind Variable-ind deleted the palette-bin branch October 11, 2023 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OverloadedOrama OverloadedOrama OverloadedOrama approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Variable-ind @OverloadedOrama