Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TileMode for selection, (plus some other fixes) #834

Merged

Conversation

Variable-ind
Copy link
Contributor

@Variable-ind Variable-ind commented Mar 12, 2023

  1. A compact version of tile-mode for selections
  2. Fixed some bugs with the ORIGINAL tile mode (Image brushes needed to be adjusted)
TileMode.mp4

@Variable-ind Variable-ind changed the title Selection tilemode TileMode for selection, (plus some other fixes) Mar 14, 2023
@OverloadedOrama
Copy link
Member

I like this, but is there a reason the UI changed from having tile mode in the tool options, to having it in the selection menu, under a Behavior sub-menu? I think the first version (as shown in your video) was better as it requires less clicks and is more visible to the user. Do you have any plans of adding more options to the Behavior sub-menu?

@Variable-ind
Copy link
Contributor Author

I like this, but is there a reason the UI changed from having tile mode in the tool options, to having it in the selection menu, under a Behavior sub-menu? I think the first version (as shown in your video) was better as it requires less clicks and is more visible to the user. Do you have any plans of adding more options to the Behavior sub-menu?

Yes but the first version used _input() continuously and it was problematic to sync both tools
The current approach is simpler and doesn't use _input()

@OverloadedOrama
Copy link
Member

In that case maybe we should keep it in the Selection menu, but make it a checkbox. If in the future there is a need to group different selection behaviors, we could create a Behavior sub-menu then.

Copy link
Member

@OverloadedOrama OverloadedOrama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@OverloadedOrama OverloadedOrama merged commit 7b189cc into Orama-Interactive:master Apr 27, 2023
@Variable-ind Variable-ind deleted the selection-tilemood branch May 6, 2023 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants