Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose pivot Option #720

Merged
merged 11 commits into from
Jul 23, 2022

Conversation

Variable-ind
Copy link
Contributor

This pull will expose the pivot option in the rotation dialog thus making it exponentially easier to make cut-out animations
A special thanks to @AlphinAlbukhari (Elid Elid) for helping me fix it for shader rotation algorithm and help in find bugs

A Demonstration of power

Demonstration.mp4

The problem was the conversion from rect to pixel scale was not properly done, i changed it so that it sets conversion factor of shorter side according to the longer side
i may have added it my self but i think its not needed now
by doing `pivot + Vector2(0.5, 0.5)` for "Nearest neighbour (Shader)"
Copy link
Member

@OverloadedOrama OverloadedOrama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@OverloadedOrama OverloadedOrama merged commit 43a8a04 into Orama-Interactive:master Jul 23, 2022
@Variable-ind Variable-ind deleted the expose_pivot branch July 24, 2022 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants