Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Luminance In Desaturate Shader #557

Merged
merged 1 commit into from
Nov 12, 2021
Merged

Use Luminance In Desaturate Shader #557

merged 1 commit into from
Nov 12, 2021

Conversation

behreajj
Copy link
Contributor

@behreajj behreajj commented Nov 8, 2021

Updated desaturate shader to use perceptual luminance instead of HSV. See https://en.wikipedia.org/wiki/HSL_and_HSV#Disadvantages

Before:

before

After:

after

Thank you for considering this pull request.
Best,
Jeremy

@behreajj
Use Luminance In Desaturate Shader
41e38a5 
Updated desaturate shader to use perceptual luminance instead of HSV.
OverloadedOrama
OverloadedOrama approved these changes Nov 12, 2021
View reviewed changes
Copy link
Member

@OverloadedOrama OverloadedOrama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Maybe in the future we could let the user choose a desaturation method like other software do, but I think this does the job for now so I'll go ahead and merge the changes. Thank you!

@OverloadedOrama OverloadedOrama merged commit 429b37f into Orama-Interactive:master Nov 12, 2021
@behreajj behreajj deleted the desaturate-luminance branch November 12, 2021 19:57
@behreajj behreajj mentioned this pull request Nov 12, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OverloadedOrama OverloadedOrama OverloadedOrama approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@behreajj @OverloadedOrama