Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update GUI for Cel.opacity on frame changed instead of on layer change #420

Merged
merged 1 commit into from
Jan 5, 2021
Merged

Update GUI for Cel.opacity on frame changed instead of on layer change #420

merged 1 commit into from
Jan 5, 2021

Conversation

kleonc
Copy link
Contributor

@kleonc kleonc commented Jan 4, 2021

It's Cel's property and thus it changes when frame_changed is called (also layer_changed calls frame_changed on its own). Fixes #419.

@kleonc
Update GUI for Cel.opacity on frame changed instead of on layer change
7584c50 
It's Cel's property and thus it changes when frame_changed is called (also layer_changed calls frame_changed on its own).
OverloadedOrama
OverloadedOrama approved these changes Jan 5, 2021
View reviewed changes
Copy link
Member

@OverloadedOrama OverloadedOrama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find! Really appreciate the detailed bug reports, as well as the fixes. Thank you!

@OverloadedOrama OverloadedOrama merged commit c18c705 into Orama-Interactive:master Jan 5, 2021
@kleonc kleonc deleted the cel_gui_updating_fix branch January 5, 2021 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OverloadedOrama OverloadedOrama OverloadedOrama approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Current cel's opacity isn't always properly updated in the GUI
2 participants
@kleonc @OverloadedOrama