-
-
Notifications
You must be signed in to change notification settings - Fork 397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pan tool #399
Add pan tool #399
Conversation
Looks great! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, functionality-wise it's very good! It will be a useful tool to have and it works well. However, I am mostly worried about the name of the tool, and its icon. A "move" tool usually refers to a tool that moves the pixels of the image (see #313) and not just the canvas. I think if we renamed it to "Pan" it would be a much better name. A hand icon, like this from Godot
also fits better for this purpose. I'd recommend using an icon like that for the Pan tool, and we can keep the one you made for a move tool that moves parts of the image.
If you could make these two changes, and if you agree of course, then I think it's ready to get merged. If you have issues making a hand icon, we could ask @Erevoid to handle that.
(Also, it's best if you avoided including files to the commit that don't have any relevant changes, like Main.tscn)
Thanks for the feedback! I am getting right at it. |
I did the renaming, but I don't think I will get a good hand icon done. |
Go ahead. You can push the changes and we can merge the PR now, and change the icon later. |
8365a27
to
aa0c3fa
Compare
Done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thank you!
The previous icons made by Schweini in #399 will be used for the new move tool.
@luiq54 the second canvas is now dragable.
I also have to learn Git better. I needed one hour for finally putting this up and 1 minute working on it in Godot.