-
-
Notifications
You must be signed in to change notification settings - Fork 398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Frame properties #357
Frame properties #357
Conversation
saving or loading and that makes crashes just the beggining :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, amazing job! The only thing I noticed that is not working properly is the canvas preview animation. It's working properly when the play button on the timeline is pressed, but not when the smaller play button next to the mini canvas is pressed. I think that would require some changes to CanvasPreview.gd
. Let me know if you wanna give it a shot, otherwise I can try and fix the issue myself.
Other than that, impressive job!
src/UI/Timeline/CelButton.gd
Outdated
@@ -7,6 +7,7 @@ onready var popup_menu : PopupMenu = $PopupMenu | |||
|
|||
|
|||
func _ready() -> void: | |||
popup_menu.add_item("Frame properties") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be better if this was in CelButton.tscn
, along with the rest of the PopupMenu
node items. When clicking the node, you will see an "Items" option on the top bar. It would be better if this gets added there, just for the sake of keeping grouped stuff together.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- About the CanvasPreview.gd: that's true I didn't see that play button and I'll try to do it myself
- About the CelButton.gd that add_item it was a provisional thing but I end it up forgeting about it I'll fixit
- Another thing now that I'm thinking about that with the new serialize and deserialize it could be problems opening old .pxo so I should fix that or there is something for this cases?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Opening old .pxo files should work, you already put a check to see if the loaded data have frame_duration
(line 337 in Project.gd). I tested opening an old pxo file and it worked, so I think it's ready.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okey! I've made the changes hope everything is ok!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you!
Frame properties update:
This is my first update a little big and my first time working in an open source project, so I'll be glad to hear any criticism but hope you like it :)
Overloaded Edit: This closes #267 and partially addresses #306.