Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New GIF export process #295

Merged
merged 1 commit into from
Aug 7, 2020

Conversation

novhack
Copy link
Contributor

@novhack novhack commented Aug 6, 2020

  • Remove godot-gifexporter submodule/plugin.
  • Add jegor377/godot-gdgifexporter entirely written in GDScript instead.
  • Add exporting of animation frames in a separate thread and an export progress bar (so Pixelorama doesn't freeze during export).
  • Remove background color option from gif export since we now support transparency - color (0,0,0,0) is used as transparent.

Massive shout out to jegor377 who wrote the exporter and Kinwailo who created median-cut quantization method and optimized most of the code.

Original PNG:

Lenna_original

Exported GIF with 256 colors on Ryzen 2600 in 8 seconds (most likely one of the worse cases):

Lenna_quality

New export progress bar:

exporting

Add exporting in a separate thread and a progress bar
Remove background color option from gif export
Copy link
Member

@OverloadedOrama OverloadedOrama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good! Amazing work guys, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants