Fixed a colorpicker bug (fixed inconsistent raw values) #1108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should probably avoid using "I" in comments, as it's not clear who is speaking, and `##` should only be used for documentation string and not normal comments.
OverloadedOrama
merged commit 51f6816
into
Orama-Interactive:master
1 of 4 checks passed
OverloadedOrama
added a commit
that referenced
this pull request
Nov 22, 2024
Variable-ind
added a commit
to Variable-ind/Pixelorama
that referenced
this pull request
Nov 26, 2024
OverloadedOrama
pushed a commit
that referenced
this pull request
Nov 29, 2024
* add a way to see indices * fix some things * Fixed more than one swatch selected if there is the same color available in an earlier swatch * fixed wrong index drawn when moved to an smpty swatch * make active_button public * fixed wrong color getting stored in array (similar fix to #1108.) * If the color selected in the palette is the same then it should take prioity. * formatting * hide 0 index
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the raw values slightly change when you select color through color picker, draw, then pick the color.
This pr fixes this.
Color.bug.mp4