Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom brushes get drawn outside of selection #9

Closed
OverloadedOrama opened this issue Sep 27, 2019 · 3 comments
Closed

Custom brushes get drawn outside of selection #9

OverloadedOrama opened this issue Sep 27, 2019 · 3 comments
Labels
help wanted Extra attention is needed

Comments

@OverloadedOrama
Copy link
Member

When the users have selected a part of the sprite, they can only draw inside of that part when using the normal pixel brush. However, I haven't managed to do the same with custom brushes because they are images that are being added to the main image layer, and not individual pixels like the pixel brush. As such, I'm not sure how to restrict the brush image's pixels to only draw inside the selection.
@OverloadedOrama OverloadedOrama added the help wanted Extra attention is needed label Sep 27, 2019
OverloadedOrama added a commit that referenced this issue Oct 3, 2019
@OverloadedOrama
Fixed issue #9 and custom brush cursor indicator position
420ec63 
- Fixed issue #9 where custom brushes would get drawn outside of a rectangle selection. They only get drawn inside the selection, just like the normal pixel brush.
- The custom brush cursor indicator (that follows the mouse cursor position) wasn't aligned with the image's pixels. Now it is.
- Fixed small bug when opening sprites. Had to do with has_focus's initial state.
- Removed Main Theme.tres because it was pointless.
@OverloadedOrama
Copy link
Member Author

Resolved as of 420ec63

@OverloadedOrama
Copy link
Member Author

Still doesn't work if the selection is smaller than the brush.

@OverloadedOrama
Copy link
Member Author

Resolved as of e18389d. For real this time, I hope.

OverloadedOrama pushed a commit that referenced this issue Dec 21, 2019
@Erevoid
Merge pull request #9 from Orama-Interactive/master
6739a2b 
δγ
OverloadedOrama pushed a commit that referenced this issue Dec 21, 2019
Merge pull request #9 from Orama-Interactive/master
803a42d 
Merge with latest
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@OverloadedOrama