Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symmetry Guides #133

Closed
Erevoid opened this issue Jan 15, 2020 · 6 comments
Closed

Symmetry Guides #133

Erevoid opened this issue Jan 15, 2020 · 6 comments
Labels
enhancement New feature or request

Comments

@Erevoid
Copy link
Member

Erevoid commented Jan 15, 2020

A neat idea would be to make a "special" kind of guide that acts like a symmetry guide. Whatever you draw relatively to the guide, not the center of the canvas as it already is with the brush options will be mirrored. Being able to move the symmetry guide around enables you to make mirrored pixels anywhere you want them. You could choose an already placed guide to act as a symmetry guide. Only one horizontal and one vertical guide are allowed at a time. Symmetry guides could be added to a sub menu, maybe the "View" menu.

@OverloadedOrama OverloadedOrama added enhancement New feature or request discussion This needs more ideas, feedback, discussion in general. labels Jan 15, 2020
@OverloadedOrama
Copy link
Member

OverloadedOrama commented Jan 15, 2020

I was thinking that symmetry guides could be visible when the user selected mirroring. If they select horizontal mirroring, horizontal symmetry guide gets visible, and same goes for vertical.

Should we have different guides for the left and right tools (that would make 4 symmetry guides in total), or is too much?

Also, what about selections? Currently, if you have a selection, the center of symmetry becomes the center of the selection, and not the canvas' center. Should the symmetry guides automatically move to the center of the selection, when the user makes one?

@Erevoid
Copy link
Member Author

Erevoid commented Jan 15, 2020

Oh, you mean whenever you choose the mirroring option the guides appear? And if they appeared as of right now they would be at the center of the canvas but you can also move them around with my idea? Well sure, but having different guides for different tools (since the eraser has its own guides too) would be too much. Also yeah, 4 guides would also be a lot in my opinion, guides should be the same for both of the left and the right tools. So instead, mirroring shouldn't be inside the tools' options, instead it should be in a neutral place, like a sub menu. Or maybe close to the l/r colors as a switchable button. Similarly, clipping mode could be a button close to the l/r colors since it will apply to all of the tools. Otherwise the sub menus would be fine. Or maybe both. As for the selection no, if the user has already set a symmetry guide, if it moves with a selection it will be spoiled.

@TheGoklayeh
Copy link

Yes, one vertical and one horizontal symmetry line for all tools should be enough.

@OverloadedOrama OverloadedOrama removed the discussion This needs more ideas, feedback, discussion in general. label Apr 11, 2020
OverloadedOrama added a commit that referenced this issue Jul 15, 2020
Instead, x_symmetry_point and y_symmetry_point are being used in Project.gd that determine the points of symmetry. This is necessary for #133
OverloadedOrama added a commit that referenced this issue Jul 16, 2020
Two special guides - one horizontal and one vertical - that let you change the axis of symmetry for mirroring. On the next commit(s) I will make them visible only if mirroring is toggled on. Almost solves #133
@bjorn
Copy link

bjorn commented Jul 22, 2020

I just tried the symmetry mode on the early_access web version (being available on the web is a great feature, btw!). I was a bit surprised that the guide was off by one on my 64x64 testing image. What is the reason for the +1 after dividing by 2?

@OverloadedOrama
Copy link
Member

Sorry about that, a miscalculation on my part. I fixed it in the latest commit, thanks for letting me know!

@TheBricktop
Copy link

TheBricktop commented Aug 11, 2022

I have similar issue
pixelorama installed from itchio launcher and its v0.10.1 stable
obraz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants