Fix memory leak when applying image effects

Orama-Interactive · Nov 10, 2023 · 7235617 · 7235617
1 parent 39c88ce
commit 7235617
Show file tree

Hide file tree

Showing 11 changed files with 0 additions and 14 deletions.
diff --git a/src/UI/Dialogs/ImageEffects/DesaturateDialog.gd b/src/UI/Dialogs/ImageEffects/DesaturateDialog.gd
@@ -28,7 +28,6 @@ func commit_action(cel: Image, project: Project = Global.current_project) -> voi
 	else:
 		var gen := ShaderImageEffect.new()
 		gen.generate_image(cel, shader, params, project.size)
-		yield(gen, "done")
 
 
 func _on_RButton_toggled(button_pressed: bool) -> void:

diff --git a/src/UI/Dialogs/ImageEffects/DropShadowDialog.gd b/src/UI/Dialogs/ImageEffects/DropShadowDialog.gd
@@ -41,7 +41,6 @@ func commit_action(cel: Image, project: Project = Global.current_project) -> voi
 	else:
 		var gen := ShaderImageEffect.new()
 		gen.generate_image(cel, shader, params, project.size)
-		yield(gen, "done")
 
 
 func _on_OffsetSliders_value_changed(_value: Vector2) -> void:

diff --git a/src/UI/Dialogs/ImageEffects/GradientDialog.gd b/src/UI/Dialogs/ImageEffects/GradientDialog.gd
@@ -124,7 +124,6 @@ func commit_action(cel: Image, project: Project = Global.current_project) -> voi
 	else:
 		var gen := ShaderImageEffect.new()
 		gen.generate_image(cel, shader, params, project.size)
-		yield(gen, "done")
 
 
 func _on_ShapeOptionButton_item_selected(index: int) -> void:

diff --git a/src/UI/Dialogs/ImageEffects/GradientMapDialog.gd b/src/UI/Dialogs/ImageEffects/GradientMapDialog.gd
@@ -22,7 +22,6 @@ func commit_action(cel: Image, project: Project = Global.current_project) -> voi
 	else:
 		var gen := ShaderImageEffect.new()
 		gen.generate_image(cel, shader, params, project.size)
-		yield(gen, "done")
 
 
 func _on_GradientEdit_updated(_gradient, _cc) -> void:

diff --git a/src/UI/Dialogs/ImageEffects/HSVDialog.gd b/src/UI/Dialogs/ImageEffects/HSVDialog.gd
@@ -38,7 +38,6 @@ func commit_action(cel: Image, project: Project = Global.current_project) -> voi
 	else:
 		var gen := ShaderImageEffect.new()
 		gen.generate_image(cel, shader, params, project.size)
-		yield(gen, "done")
 
 
 func _reset() -> void:

diff --git a/src/UI/Dialogs/ImageEffects/InvertColorsDialog.gd b/src/UI/Dialogs/ImageEffects/InvertColorsDialog.gd
@@ -29,7 +29,6 @@ func commit_action(cel: Image, project: Project = Global.current_project) -> voi
 	else:
 		var gen := ShaderImageEffect.new()
 		gen.generate_image(cel, shader, params, project.size)
-		yield(gen, "done")
 
 
 func _on_RButton_toggled(button_pressed: bool) -> void:

diff --git a/src/UI/Dialogs/ImageEffects/OffsetImage.gd b/src/UI/Dialogs/ImageEffects/OffsetImage.gd
@@ -42,7 +42,6 @@ func commit_action(cel: Image, project: Project = Global.current_project) -> voi
 	else:
 		var gen := ShaderImageEffect.new()
 		gen.generate_image(cel, shader, params, project.size)
-		yield(gen, "done")
 
 
 func _on_OffsetSliders_value_changed(_value: Vector2) -> void:

diff --git a/src/UI/Dialogs/ImageEffects/OutlineDialog.gd b/src/UI/Dialogs/ImageEffects/OutlineDialog.gd
@@ -50,7 +50,6 @@ func commit_action(cel: Image, project: Project = Global.current_project) -> voi
 	else:
 		var gen := ShaderImageEffect.new()
 		gen.generate_image(cel, shader, params, project.size)
-		yield(gen, "done")
 
 
 func _on_ThickValue_value_changed(value: int) -> void:

diff --git a/src/UI/Dialogs/ImageEffects/Posterize.gd b/src/UI/Dialogs/ImageEffects/Posterize.gd
@@ -24,7 +24,6 @@ func commit_action(cel: Image, project: Project = Global.current_project) -> voi
 	else:
 		var gen := ShaderImageEffect.new()
 		gen.generate_image(cel, shader, params, project.size)
-		yield(gen, "done")
 
 
 func _on_LevelsSlider_value_changed(value: float) -> void:

diff --git a/src/UI/Dialogs/ImageEffects/RotateImage.gd b/src/UI/Dialogs/ImageEffects/RotateImage.gd
@@ -128,7 +128,6 @@ func commit_action(cel: Image, _project: Project = Global.current_project) -> vo
 			else:
 				var gen := ShaderImageEffect.new()
 				gen.generate_image(cel, rotxel_shader, params, _project.size)
-				yield(gen, "done")
 
 		CLEANEDGE:
 			var params := {
@@ -147,7 +146,6 @@ func commit_action(cel: Image, _project: Project = Global.current_project) -> vo
 				params["preview"] = false
 				var gen := ShaderImageEffect.new()
 				gen.generate_image(cel, DrawingAlgos.clean_edge_shader, params, _project.size)
-				yield(gen, "done")
 		OMNISCALE:
 			var params := {
 				"angle": angle,
@@ -163,7 +161,6 @@ func commit_action(cel: Image, _project: Project = Global.current_project) -> vo
 				params["preview"] = false
 				var gen := ShaderImageEffect.new()
 				gen.generate_image(cel, DrawingAlgos.omniscale_shader, params, _project.size)
-				yield(gen, "done")
 		NNS:
 			var params := {
 				"angle": angle,
@@ -177,7 +174,6 @@ func commit_action(cel: Image, _project: Project = Global.current_project) -> vo
 			else:
 				var gen := ShaderImageEffect.new()
 				gen.generate_image(cel, nn_shader, params, _project.size)
-				yield(gen, "done")
 		ROTXEL:
 			DrawingAlgos.rotxel(image, angle, pivot)
 		NN:

diff --git a/src/UI/Dialogs/ImageEffects/ShaderEffect.gd b/src/UI/Dialogs/ImageEffects/ShaderEffect.gd
@@ -30,7 +30,6 @@ func commit_action(cel: Image, project: Project = Global.current_project) -> voi
 	var gen := ShaderImageEffect.new()
 	gen.generate_image(cel, shader, params, project.size)
 	selected_cels.unlock()
-	yield(gen, "done")
 
 
 func _on_ChooseShader_pressed() -> void: