Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update dockerfile logic #46

Merged
merged 3 commits into from
Nov 18, 2021
Merged

update dockerfile logic #46

merged 3 commits into from
Nov 18, 2021

Conversation

mkrouse
Copy link
Collaborator

@mkrouse mkrouse commented Nov 18, 2021

Proposed changes

Issues for these changes

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (changes to code, which do not change application behavior)

Checklist

  • I have filled out this PR template
  • I have read the CONTRIBUTING doc
  • I have added automated tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (README.md, CHANGELOG.md, etc. - if appropriate)

Dependencies and Blockers

Relevant Links

Further comments

@CLAassistant
Copy link

CLAassistant commented Nov 18, 2021

CLA assistant check
All committers have signed the CLA.

@github-actions
Copy link

github-actions bot commented Nov 18, 2021

Unit Test Results

  1 files  15 suites   0s ⏱️
54 tests 54 ✔️ 0 💤 0

Results for commit aeee2d3.

♻️ This comment has been updated with latest results.

@mkrouse mkrouse changed the title update variable update dockerfile logic Nov 18, 2021
@mkrouse mkrouse merged commit aeee2d3 into main Nov 18, 2021
@mkrouse mkrouse deleted the dockerfile-patch branch November 18, 2021 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants