Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/regional regions cli #38

Merged
merged 3 commits into from
Oct 18, 2021
Merged

Conversation

tiny-dancer
Copy link
Contributor

@tiny-dancer tiny-dancer commented Oct 18, 2021

Proposed changes

  • bug fix regional regions not being respected as a cli flag when primary not passed
    • BREAKING CHANGE: primary region is not automatically appended to regional regions in cli flags
  • added ability to pass in a dockerfile to have runiac build

Issues for these changes

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (changes to code, which do not change application behavior)

Checklist

  • I have filled out this PR template
  • I have read the CONTRIBUTING doc
  • I have added automated tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (README.md, CHANGELOG.md, etc. - if appropriate)

Dependencies and Blockers

Relevant Links

Further comments

@github-actions
Copy link

github-actions bot commented Oct 18, 2021

Unit Test Results

  1 files  15 suites   0s ⏱️
53 tests 53 ✔️ 0 💤 0

Results for commit 0910549.

♻️ This comment has been updated with latest results.

@tiny-dancer tiny-dancer self-assigned this Oct 18, 2021
@tiny-dancer tiny-dancer merged commit 0910549 into main Oct 18, 2021
@tiny-dancer tiny-dancer deleted the bugfix/regional-regions-cli branch October 18, 2021 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant