Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Persist AWS CLI configuration in .runiac directory #33

Merged
merged 1 commit into from
May 31, 2021

Conversation

mbpolan
Copy link
Member

@mbpolan mbpolan commented May 31, 2021

Proposed changes

In preparation to support a new AWS starter project.

Persist and copy the AWS CLI config directory in .runiac. This provides the same login-once experience that the Azure and GCP entrypoint.sh scripts offer.

Issues for these changes

N/A

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (changes to code, which do not change application behavior)

Checklist

  • I have filled out this PR template
  • I have read the CONTRIBUTING doc
  • [] I have added automated tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (README.md, CHANGELOG.md, etc. - if appropriate)

Dependencies and Blockers

N/A

Relevant Links

Further comments

N/A

@mbpolan mbpolan added the enhancement New feature or request label May 31, 2021
@mbpolan mbpolan self-assigned this May 31, 2021
@mbpolan mbpolan marked this pull request as ready for review May 31, 2021 22:39
@mbpolan mbpolan requested a review from tiny-dancer May 31, 2021 22:39
@tiny-dancer
Copy link
Contributor

@mbpolan does this pull request come with a hello world starter?

@tiny-dancer tiny-dancer changed the title Persist AWS CLI configuration in .runiac directory feat: Persist AWS CLI configuration in .runiac directory May 31, 2021
@tiny-dancer tiny-dancer merged commit 9095961 into main May 31, 2021
@tiny-dancer tiny-dancer deleted the feature/copy-aws-cli branch May 31, 2021 22:42
@github-actions
Copy link

Unit Test Results

  1 files  15 suites   0s ⏱️
53 tests 53 ✔️ 0 💤 0 ❌

Results for commit 9095961.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants