Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated creating an AWS account #425

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

eric-w-hart
Copy link

Proposed changes

Updated the how to get started with AWS section. Added graphics and instructions.

Updated documentation.

Types of changes

Updated instructions.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (changes to code, which do not change application behavior)

Checklist

  • I have filled out this PR template
  • I have read the CONTRIBUTING doc
  • I have added automated tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (README.md, inline comments, etc.)
  • I have updated the CHANGELOG.md under a ## next release, with a short summary of my changes

Relevant Links

Further comments

Added instructions for Getting Started.
uploading screen grabs for creating aws account and login
added more getting started content and images for reference
uploading account image
@amyschoen
Copy link
Member

docs/img/aws_account_id_iam_console.png might be problematic since I see an account number listed. Is this still an active account?

@amyschoen amyschoen requested a review from shubydo July 6, 2022 22:04
shubydo
shubydo previously approved these changes Jul 6, 2022
@eric-w-hart
Copy link
Author

No. It's an inactive account only used for the purpose of creating the screenshot.

changed ubuntu version to 20.04 instead of latest tag.
shubydo
shubydo previously approved these changes Jul 7, 2022
@eric-w-hart
Copy link
Author

@shubydo can you run the dce check?

@shubydo
Copy link
Collaborator

shubydo commented Jan 14, 2023

@shubydo can you run the dce check?

Done. Sorry for the delay.

CHANGELOG.md Show resolved Hide resolved
Copy link
Collaborator

@shubydo shubydo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment on CHANGELOG. Overall LGTM

CHANGELOG.md Show resolved Hide resolved
Copy link
Collaborator

@shubydo shubydo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM. Pull latest changes/rebase with upstream + fix conflicts and it should be able to be merged.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants