-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated creating an AWS account #425
base: master
Are you sure you want to change the base?
Conversation
Added instructions for Getting Started.
uploading screen grabs for creating aws account and login
added more getting started content and images for reference
uploading account image
docs/img/aws_account_id_iam_console.png might be problematic since I see an account number listed. Is this still an active account? |
No. It's an inactive account only used for the purpose of creating the screenshot. |
changed ubuntu version to 20.04 instead of latest tag.
Update CHANGELOG.md
Update pipeline.yml
@shubydo can you run the dce check? |
Done. Sorry for the delay. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comment on CHANGELOG. Overall LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM. Pull latest changes/rebase with upstream + fix conflicts and it should be able to be merged.
|
Proposed changes
Updated the how to get started with AWS section. Added graphics and instructions.
Updated documentation.
Types of changes
Updated instructions.
Checklist
README.md
, inline comments, etc.)CHANGELOG.md
under a## next
release, with a short summary of my changesRelevant Links
Further comments