update docs #44
Merged
update docs #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrkrshnn
approved these changes
Oct 21, 2022
Comment on lines
+5
to
+10
| In order to commit your contract, call function `commit(bytes32 key)` where | ||
| `key = keccak256(abi.encode(sender, codehash, salt))`, `sender` is the address | ||
| you intend to use when performin the challenge, `codehash` is the code hash of | ||
| your solution contract, and `salt` is any number of your choice. This will | ||
| (hopefully) make sure that you do not know the challenge inputs in advance, and | ||
| that only you can use your contract. |
There was a problem hiding this comment.
We should probably add that the salting is done so that an external observer wouldn't be able to know the contract that solves the challenge in advance.
Comment on lines
+15
to
+16
| should be the owner of the newly minted NFT, in case you become the leader; and | ||
| `salt` must be the same you passed when committing. |
There was a problem hiding this comment.
We should just say that the salt should match the one you used to commit.
hrkrshnn
reviewed
Oct 21, 2022
| know the challenge inputs in advance, and that only you can use your contract. | ||
| In order to commit your contract, call function `commit(bytes32 key)` where | ||
| `key = keccak256(abi.encode(sender, codehash, salt))`, `sender` is the address | ||
| you intend to use when performin the challenge, `codehash` is the code hash of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.