Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit Tests! #2

Closed
wgnf opened this issue Oct 23, 2021 · 0 comments · Fixed by #21
Closed

Unit Tests! #2

wgnf opened this issue Oct 23, 2021 · 0 comments · Fixed by #21

Comments

@wgnf
Copy link
Member

wgnf commented Oct 23, 2021

No description provided.

wgnf added a commit that referenced this issue Oct 31, 2021
wgnf added a commit that referenced this issue Nov 1, 2021
wgnf added a commit that referenced this issue Nov 1, 2021
wgnf added a commit that referenced this issue Nov 1, 2021
wgnf added a commit that referenced this issue Nov 1, 2021
@wgnf wgnf closed this as completed in #21 Nov 1, 2021
wgnf added a commit that referenced this issue Nov 1, 2021
* ci: run dependabot every week

because this clearly does not need to be run every day

* refactor: redo the whole workflow

because the workflow before was strictly coupled to the manual component of moving and processing files.
The new approach builds on a job-pool which can be worked on whenever a worker is free.

Closes #6, Closes #7, Closes #17

* refactor: remove unnecessary usage of cancellation token

* test: add tests for background services

this addresses #2

* test: add tests for ApplyRulesToCsvFile

this addresses #2

* refactor: add CsvReader and CsvWriter factories

so that the using components of these two - CsvExporter, CsvImporter - can actually be unit-tested, because they're independent from Stream-Magic now

* test: add tests for CsvExporter

this addresses #2

* test: add tests for CsvImporter

this addresses #2

* test: add tests for remaining stuff

this addresses #2

* style: clean up code

thanks R# :)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant