Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

S3task #83

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

S3task #83

wants to merge 10 commits into from

Conversation

raghuramopsmx
Copy link

Please review and verify all configuration changes

abhinaybyrisetty
abhinaybyrisetty reviewed Feb 5, 2021
View reviewed changes
charts/oes/charts/spinnaker/templates/configmap/halyard-init-script.yaml
sed -i s/SPINNAKER_NAMESPACE/${SPINNAKER_NAMESPACE}/ /tmp/spinnaker/.hal/config
{{- end }}

{{- else }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These s3 instructions will be executed even if repo type is not s3, so it should be handled properly. Let's say repoType is not s3, not git, but "vault" even then this conditon will be hit and executed. So, handle it something like below

{{- else if eq .Values.gitopsHalyard.repoType "s3" }}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhinaybyrisetty abhinaybyrisetty abhinaybyrisetty requested changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@raghuramopsmx @abhinaybyrisetty